Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test viability of fast-glob replacements (fdir or tinyglobby) #3167

Closed
zachleat opened this issue Jan 18, 2024 · 7 comments
Closed

Test viability of fast-glob replacements (fdir or tinyglobby) #3167

zachleat opened this issue Jan 18, 2024 · 7 comments
Labels
enhancement: favorite Vanity label! The maintainer likes this enhancement request a lot. enhancement needs-votes A feature request on the backlog that needs upvotes or downvotes. Remove this label when resolved.
Milestone
Eleventy 4.0.0

Comments

@zachleat
Copy link
Member

https://www.npmjs.com/package/fdir

found this one via @rphillips-nz!
@zachleat
Copy link
Member Author

zachleat commented Apr 8, 2024

Note also that fs.glob and fs.globSync are coming to Node! nodejs/node#51912

@mehulkar mehulkar mentioned this issue Apr 13, 2024
Open
@zachleat zachleat added needs-votes A feature request on the backlog that needs upvotes or downvotes. Remove this label when resolved. enhancement: favorite Vanity label! The maintainer likes this enhancement request a lot. labels Jun 19, 2024
@zachleat
Copy link
Member Author

This repository is now using lodash style issue management for enhancements. This means enhancement issues will now be closed instead of leaving them open.

View the enhancement backlog here. Don’t forget to upvote the top comment with 👍!

@zachleat zachleat closed this as not planned Won't fix, can't repro, duplicate, stale Jun 19, 2024
@zachleat zachleat changed the title Test viability of fdir replacement for fast-glob Test viability of fast-glob replacements (fdir or tinyglobby) Dec 13, 2024
@zachleat
Copy link
Member Author

zachleat commented Dec 13, 2024 •
edited
Loading

tinyglobby recommendation at #3586 via @Ryuno-Ki

@zachleat zachleat mentioned this issue Dec 13, 2024
Closed
@zachleat zachleat added this to the Eleventy 4.0.0 milestone Dec 13, 2024
This was referenced Jan 17, 2025
Open
Closed
@zachleat
Copy link
Member Author

zachleat commented Mar 5, 2025

another vote for tinyglobby from @43081j: https://bsky.app/profile/43081j.com/post/3ljnbo7qlzk24

@43081j
Copy link

43081j commented Mar 5, 2025

Also I feel like is-glob can be replaced by tinyglobby (@SuperchupuDev Will know)

@zachleat
Copy link
Member Author

zachleat commented Mar 5, 2025

e18e/ecosystem-issues#140

@43081j 43081j mentioned this issue Mar 5, 2025
Open
@SuperchupuDev
Copy link

Also I feel like is-glob can be replaced by tinyglobby (@SuperchupuDev Will know)

pretty sure it can with isDynamicPattern, worst case picomatch.scan().isGlob can be used (picomatch is already a tinyglobby dependency)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement: favorite Vanity label! The maintainer likes this enhancement request a lot. enhancement needs-votes A feature request on the backlog that needs upvotes or downvotes. Remove this label when resolved.
Projects
None yet
Milestone
Eleventy 4.0.0
Development

No branches or pull requests
3 participants
@zachleat @43081j @SuperchupuDev