LG-12534 FSM clean up #11578
Open
LG-12534 FSM clean up #11578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduth
reviewed
Dec 2, 2024
There was a problem hiding this comment.
This file removal is a long time coming! Excited to see it happening.
There was a problem hiding this comment.
Same! Go @jennyverdeyen!
jennyverdeyen
force-pushed
the
jverdeyen/LG-12534-FSM-clean-up
branch
from
f9d621b to
7174c83
Compare
jennyverdeyen
changed the title
jennyverdeyen
force-pushed
the
jverdeyen/LG-12534-FSM-clean-up
branch
3 times, most recently
from
b8e2b3b to
2162849
Compare
…on controller changelog: Internal, In-person proofing, cleaning up unused FSM code
…s breaking after removing the dynamic FSM /:step route
jennyverdeyen
force-pushed
the
jverdeyen/LG-12534-FSM-clean-up
branch
from
6b536d8 to
4386652
Compare
jennyverdeyen
changed the title
eileen-nava
approved these changes
Jan 16, 2025
| :set_usps_form_presenter, | ||
| :redirect_unless_enrollment, | ||
| :initialize_in_person_session, |
There was a problem hiding this comment.
Good to see this added. 💪🏻
There was a problem hiding this comment.
I was going to ask if there's a benefit to increasing test coverage for the functionality of theinitialize_in_person_session method, but I realize it's tricky to test private methods. I'm curious what you think.
There was a problem hiding this comment.
Same! Go @jennyverdeyen!
| step = local_assigns[:action] || local_assigns[:step] | ||
| path = (step_url && step) ? send(step_url, step: step) : go_back_path | ||
| path = go_back_path |
aduth
reviewed
Jan 16, 2025
Comment on lines
-14
to
-16
| step_url = local_assigns[:step_url] || @step_url | ||
| step = local_assigns[:action] || local_assigns[:step] | ||
| path = (step_url && step) ? send(step_url, step: step) : go_back_path |
There was a problem hiding this comment.
Can we update the code documentation above to remove action and step_url if they're no longer relevant?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
Link to the relevant ticket:
LG-12534
🛠 Summary of changes
Removes remaining Flow State Machine related files and references
📜 Testing Plan
No new functionality is being added, but manual regression testing is needed to ensure nothing has been adversely affected.