LG-15000: Remove in_person_please_call email #11664
Conversation
matthinz
force-pushed
the
matthinz/15000-idv-please-call-part-2
branch
from
e917b8a to
6360574
Compare
matthinz
force-pushed
the
matthinz/15000-idv-please-call-part-3
branch
from
6975326 to
3cf4651
Compare
matthinz
force-pushed
the
matthinz/15000-idv-please-call-part-2
branch
2 times, most recently
from
10eecd3 to
51cc5a3
Compare
- Slightly improve error output - Capture behavior in a dedicated spec [skip changelog]
Assert that a certain email was not sent.
These specs weren't actually testing the thing we thought they were, since the text_part of the email did not contain HTML.
This is the exact same email, content-wise, just with a new name to reflect the fact that it is used throughout idv. [skip changelog]
matthinz
force-pushed
the
matthinz/15000-idv-please-call-part-2
branch
from
51cc5a3 to
c50cb70
Compare
Many clients won't display inline images referenced by URL for privacy reasons.
This has been renamed to idv_please_call. [skip changelog]
matthinz
force-pushed
the
matthinz/15000-idv-please-call-part-3
branch
from
3cf4651 to
5b4faea
Compare
| @@ -2,7 +2,7 @@ | |||
| require_relative './user_mailer_preview' | |||
|
|
|||
| RSpec.describe UserMailerPreview do | |||
| it_behaves_like 'a mailer preview', preview_methods_that_can_be_missing: [:in_person_please_call] | |||
There was a problem hiding this comment.
Academic curiosity: Is preview_methods_that_can_be_missing a metaprogramming thing I'm not aware of, or was this just a symbolic note for humans? I don't see this as a method anywhere.
There was a problem hiding this comment.
This is just some syntactic sugar. Rewritten:
it_behaves_like(
'a mailer preview',
{ preview_methods_that_can_be_missing:[:in_person_please_call] }
)Where the first argument is the name of the shared example and anything after is an argument passed to the parameterized example.
There was a problem hiding this comment.
issue: This method is also called in GetUspsProofingResultsJob. (I don't understand how the spec for that job is passing if you've eliminated the method though.
In GetUspsProofingResultsJob
https://github.com/18F/identity-idp/blob/main/app/jobs/get_usps_proofing_results_job.rb#L610-L619
In the get_usps_proofing_results_job_spec:
identity-idp/spec/jobs/get_usps_proofing_results_job_spec.rb
Lines 1547 to 1551 in 842401c
Dang it, I misremembered the initial description as 1 of 3. 🫠 |
(This PR is 3 of 3. It can't be merged until #11604 and #11662 are in production)
🎫 Ticket
Link to the relevant ticket:
LG-15000
🛠 Summary of changes
#11604 added a new
idv_please_callemail, which is identical toin_person_please_call.#11662 started sending that email from other parts of IDV and updated the in-person code to send
idv_please_callinstead ofin_person_please_callThis PR removes references to
in_person_please_call.