[DO NOT REVIEW] [WIP] LG-15187: Update Socure A/B test logic, Pt.2 #11685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a new parameter to ResolutionProofingJob prior to implementation, so that the new signature method can be used once all job queues are running the same code. [skip changelog]
lmgeorge
changed the title
Update this spec to use more let and subject blocks ahead of adding new tests to it. [skip changelog]
Assert we're actually passing proofing components into ResolutionProofingJob
Handle logic around shadow mode enabled / disabled globally, shadow mode enabled for docv users, and shadow mode a/b test for non-docv users.
Tests can get stuck with mocked configs, leading to flakiness. [skip changelog]
|
closed and reopened as #11694 11694 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 2/2 for LG-15187
🛠 Summary of changes
TBD
🎫 Ticket
Link to the relevant ticket:
LG-15187