Deploy RC 441 to Production #11695
Merged
Deploy RC 441 to Production #11695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We missed this when we got rid of the ProofingComponent model in #11564 [skip changelog]
* Rework mailer_helper and add spec - Slightly improve error output - Capture behavior in a dedicated spec [skip changelog] * Add expect_email_not_delivered helper Assert that a certain email was not sent. * Update alert_user_about_account_verified_spec These specs weren't actually testing the thing we thought they were, since the text_part of the email did not contain HTML.
changelog: User-Facing Improvements, Accessibility, skipnav container no longer blocks content at large zoom levels
changelog: Internal, Code Quality, Remove unused code
* initial draft * changelog: Upcoming Features, Authentication, move tmx to mfa setup page * update rubocop * update setup * update registrations controller and setup controller * remove unneeded check * use user session instead of session * update mfa setup concern session id * update threatmetrix specs * fix linting issue * move device mock result * add some spacing at the bottom for threatmetrix * fix lint
* Allow pasting PR url in create-release script Previously this script required you to get the actual PR ID. This update allows you to just paste in the PR URL directly, which is slightly faster. [skip changelog] * Use GH_REPO in the pattern passed to sed Also, make comparison case-insensitive (because technically we are 18F/identity-idp, not 18f/identity-idp?
* Rework mailer_helper and add spec - Slightly improve error output - Capture behavior in a dedicated spec [skip changelog] * Add expect_email_not_delivered helper Assert that a certain email was not sent. * Update alert_user_about_account_verified_spec These specs weren't actually testing the thing we thought they were, since the text_part of the email did not contain HTML. * Update IPP code to use idv_please_call email This is the exact same email, content-wise, just with a new name to reflect the fact that it is used throughout idv. [skip changelog] * Send idv_please_call for GPO verification * Send 'Please Call' email for phone verification users * Attach phone_icon.png rather than referencing by URL Many clients won't display inline images referenced by URL for privacy reasons.
…1674) * Start writing resolution vendor(s) to idv_session Save what vendors were used for resolution of the state ID address + residential address. [skip changelog] * Copy-paste resolution vendor test into IPP verify info controller spec * Ensure resolution vendors are reset on undo - Add a test for undoing verify info - Ensure that the new resolution vendor keys are undid * Update undo_step for IPP VerifyInfoController * Use idv_session resolution vendors for ProofingComponents Include a 50/50 state consideration for now. * Lint fixes * Update analytics feature spec * Update idv end-to-end spec
If a user is returned from Socure and is waiting too long for their data to be fetched, they are redirected to the Timeout page where they can either Try again, Try in person (if available), or Cancel. changelog: Upcoming Features, Identity Verification, Socure timeout provides users with options. * updates to copy for timeout page, specs * fix the timeout template, check for in_person_enabled? * gymnastics to enter the IPP flow * renamed warning spec to timeout spec * log an event on choosing In Person * spec for socure_errors_controller * Move the direct_to_in_person route to the DocumentCaptureController. Rename Idv::Socure::SocureErrorsController to Idv::Socure::ErrorsController * feature spec: time out takes you to the Try Again page * remove outdated spec * reorg document_capture_controller_spec.rb to include `it`s before `context`s * spec for document_capture_controller#direct_in_person * remove `go_in_person` from socure errors concern * refactoring two socure error controllers into one * hybrid path can't use errors_controller - no idv_session --------- Co-authored-by: John Maxwell <[email protected]> Co-authored-by: Amir Reavis-Bey <[email protected]>
changelog: Upcoming Features, Partner account, Select email to share with partner - Refactor: add method ServiceProviderIdentity#email_address_for_sharing that does the right thing - Add tests to verify correct behavior in SAML and OIDC - Eliminate EmailContext class that seemed to be of limited value - Create method EmailAddress#last_sign_in - Remove code duplication from SAML and OIDC - Get rid of EmailContext - Get rid of `reek` remnants - Fix minor typos
Translations interpolate SP name Due to a misunderstanding with DOS, the translations had the literal string "service provider". Fixed! Conditionally hides the display if there is no SP (which shouldn't happen in prod) because otherwise the message is nonsense and has no clickable link text.
mitchellhenke
requested review from
n1zyy,
matthinz,
aduth,
vrajmohan,
solipet and
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User-Facing Improvements
Internal
Upcoming Features