Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing error messages to zxcvbn en.yml #5776

Merged
merged 3 commits into from
Jan 5, 2022
Merged

Add missing error messages to zxcvbn en.yml #5776

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4b82d3d
Add missing error messages to zxcvbn en.yml
nathanberg Jan 4, 2022
ea601a7
Add missing translations for zxcvbn messages
nathanberg Jan 4, 2022
0ed9403
Add additional missing translations
nathanberg Jan 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions config/locales/zxcvbn/en.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ en:
For a stronger password, use a few words separated by spaces, but avoid
common phrases
names_and_surnames_by_themselves_are_easy_to_guess: Names and surnames by themselves are easy to guess
no_need_for_symbols_digits_or_uppercase_letters: No need for symbols, digits, or uppercase letters
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we'll need to request spanish and fresh translations of these strings (which is why the specs are failing)

some info here: https://handbook.login.gov/articles/appdev-i18n.html#translating-content-guidance

predictable_substitutions_like__instead_of_a_dont_help_very_much: Predictable substitutions like ‘@’ instead of ‘a’ don’t help very much
recent_years_are_easy_to_guess: Recent years are easy to guess
repeats_like_aaa_are_easy_to_guess: Repeats like “aaa” are easy to guess
Expand All @@ -30,4 +31,5 @@ en:
this_is_a_top_100_common_password: This is a top-100 common password
this_is_a_very_common_password: This is a very common password
this_is_similar_to_a_commonly_used_password: This is similar to a commonly used password
use_a_few_words_avoid_common_phrases: Use a few words, avoid common phrases
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like this one is still missing in spanish, french:

> bundle exec i18n-tasks missing
Missing translations (2) | i18n-tasks v0.9.35
+--------+------------------------------------------------------+------------------------------------------+
| Locale | Key                                                  | Value in other locales or source         |
+--------+------------------------------------------------------+------------------------------------------+
|   es   | zxcvbn.feedback.use_a_few_words_avoid_common_phrases | en Use a few words, avoid common phrases |
|   fr   | zxcvbn.feedback.use_a_few_words_avoid_common_phrases | en Use a few words, avoid common phrases |
+--------+------------------------------------------------------+------------------------------------------+

use_a_longer_keyboard_pattern_with_more_turns: Use a longer keyboard pattern with more turns
1 change: 1 addition & 0 deletions config/locales/zxcvbn/es.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ es:
Para una contraseña más segura, use pocas palabras separadas por
espacios, pero evite frases comunes
names_and_surnames_by_themselves_are_easy_to_guess: Nombres y apellidos por si solos son fáciles de adivinar
no_need_for_symbols_digits_or_uppercase_letters: No necesita usar símbolos, cifras ni mayúsculas
predictable_substitutions_like__instead_of_a_dont_help_very_much: No hay necesidad de símbolos, dígitos o letras mayúsculas
recent_years_are_easy_to_guess: Sustituciones predecibles como ‘@’ en lugar de ‘a’ no ayudan mucho
repeats_like_aaa_are_easy_to_guess: Los años recientes son fáciles de adivinar
Expand Down
1 change: 1 addition & 0 deletions config/locales/zxcvbn/fr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ fr:
Pour créer un mot de passe plus fort, utilisez quelques mots séparés par
des espaces, mais évitez les phrases communes
names_and_surnames_by_themselves_are_easy_to_guess: Les prénoms et noms de famille seuls sont faciles à deviner
no_need_for_symbols_digits_or_uppercase_letters: Pas besoin de symboles, de chiffres ou de lettres majuscules
predictable_substitutions_like__instead_of_a_dont_help_very_much:
Les remplacements prévisibles comme es « @ » au lieu de « à » n’aident
pas beaucoup
Expand Down