Conversation
Old one will be removed with the next breaking release cycle.
Avoid the breaking change, for now, by simply deprecating the methods and introducing an internal bool switch in the public iterator. This hack will be removed in the next major version.
Owner
Author
|
This fails due to nightly breakage, that would only affect testability of a dependency of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the interface issues discovered in #39.
Deprecates the broken interface, they will be removed in the next major version. We avoid a breaking change in the case of private extension iteration by introducing a boolean flag to turn the public extension iterator into the private one. Renames the constructors for both iterators to a more 'rusty' version which is more similar to
HashMap::keysand other specialized container iterators.This fixes a bug where the
Assertiongrant type could silently discard private extensions instead of returning with an error.