fix build and run on mac osx#16
Open
gilwo wants to merge 3 commits into
Open
Conversation
The image-dimensions fast path is exercised only by tests, so the production build flagged it as unused. Mark it #[allow(dead_code)] to keep the API and its test coverage while restoring a warning-free build. Cargo.lock picks up routine point-release dependency bumps from the rebuild. Powered-By: Claude Opus 4.8 (1M context)
The REPL spawns tokio::io::stdin(), which reads on a blocking background thread parked in a read() syscall. On SIGINT the bridge drained and main returned, but the runtime's drop blocked forever waiting on that stuck reader whenever stdin stayed open (interactive terminal or live pipe) — so the process only exited cleanly when stdin was closed/redirected. Make the REPL loop break on the cancel token via tokio::select!, and exit explicitly with std::process::exit(0) after graceful shutdown completes so the parked stdin thread can't keep the process alive. Verified: SIGINT with stdin held open now exits in ~2s, code 0, no kill -9 needed. Powered-By: Claude Opus 4.8 (1M context)
handle_event (608 lines) → extract_content_inner (420 lines) generates a massive async state machine that overflows tokio's default 2 MB worker stack in debug builds, causing silent "stack overflow, aborting" crashes whenever inbound WhatsApp messages arrive. Switching from #[tokio::main] to a manual runtime builder with 8 MB stacks eliminates the overflow. Powered-By: Claude Opus 4.8 (1M context)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
had couple of issues when trying to build on mac osx: