Skip to content

chore(deps): update b3log/siyuan docker tag to v3.1.18 #2877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wanghe-fit2cloud merged 2 commits into from
Jan 2, 2025
Merged

chore(deps): update b3log/siyuan docker tag to v3.1.18 #2877

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
91d9c93
chore(deps): update b3log/siyuan docker tag to v3.1.18
renovate[bot] Dec 31, 2024
0f33bf4
Update app version [skip ci]
Dec 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
0 apps/siyuan/3.1.17/data.yml → apps/siyuan/3.1.18/data.yml
View file
Open in desktop
File renamed without changes.
0 apps/siyuan/3.1.17/data/.gitkeep → apps/siyuan/3.1.18/data/.gitkeep
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion apps/siyuan/3.1.17/docker-compose.yml → apps/siyuan/3.1.18/docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
services:
siyuan:
image: b3log/siyuan:v3.1.17
image: b3log/siyuan:v3.1.18
container_name: ${CONTAINER_NAME}
restart: unless-stopped
ports:
Copy link
Copy Markdown
Member

@wanghe-fit2cloud wanghe-fit2cloud Dec 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an update to the image field from b3log/siyuan:v3.1.17 to b3log/siyuan:v3.1.18, which suggests that there has been a new release available on Docker Hub for SiYuan. This could be due to bug fixes, feature improvements, or security updates.

Potential Issues: There may not be any known issues with this specific version of SiYuan based solely on its name change. However, it's good practice to review the changelog for both versions to ensure no critical changes were made.

Optimization Suggestions:

  1. Use Tag Constraints: Ensure your Kubernetes manifest (e.g., Deployment.yaml) specifies exact tags instead of using a range (v3.1.*). This allows better control over the image used and can help avoid unexpected behavior during upgrades.

    apiVersion: apps/v1
kind: Deployment
metadata:
  labels:
    app: siyuan-svc
  name: siyuan-service
spec:
  replicas: 1
  strategy:
    type: RollingUpdate
  selector:
    matchLabels:
      app: siyuan-svc
  template:
    metadata:
      labels:
        app: siyuan-svc
    spec:
      containers:
      - image: b3log/siyuan:v3.1.18
        container_name: ${CONTAINER_NAME}
        restartPolicy: UnlessStopped
        ports:
          - containerPort: 6835
            protocol: TCP

  2. Environment Variables: If you need to set environment variables specific to different production environments (Dev/Staging/Production), consider encapsulating them within separate config maps or secrets rather than hardcoding in your deployment files. This improves maintainability and scalability.

  3. Consider Upgrading Dependencies:** Check if there are any compatibility requirements between the updated SiYuan version and other components such as database drivers, plugins, or third-party tools being used in your SIYuan instance. Upgrade dependencies only in cases where they resolve conflicts or improve performance.

  4. Backup Strategy: Ensure you have a robust backup process in place before making significant updates like these. A complete dump of all data plus configuration settings should be stored separately.

By addressing these areas, you can minimize downtime and ensure smooth operation of the SiYuan service after updating to v3.1.18.

Expand Down
0 apps/siyuan/3.1.17/scripts/init.sh → apps/siyuan/3.1.18/scripts/init.sh
View file
Open in desktop
File renamed without changes.