Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some issues with bootstrap modals #19

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Bloodmallet
Copy link

This PR contains the following changes for bootstrap modals:

  • variable names are consistently modal* now
  • added modalTitleId as id to the modal title (h5)
  • use modal id variable instead of "exampleModal"
  • indentation uses 4 spaces everywhere
  • deleted some indentations that were wrong

Thank you for this code addon. I hope this PR is deemed useful. After all I stumbled upon these issues when using it.

@Bloodmallet Bloodmallet changed the title fix variable names, fix indentation, add title id Fix some issues with bootstrap modals May 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant