Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 0.3.9 #354

Merged
merged 3 commits into from
Apr 12, 2022
Merged

Release 0.3.9 #354

merged 3 commits into from
Apr 12, 2022

Conversation

daria-lasecka
Copy link
Contributor

@daria-lasecka daria-lasecka commented Apr 7, 2022 •
edited
Loading

Issue: PATIENTAPP-139

PR Checklist
  • Give this PR a meaningful title
  • Add a link to the related issue at the top of this description (above)
  • Connect this PR with the related issue via ZenHub with the button below this text box (or at the bottom of the page after the PR is created)
  • Ensure your branch is up to date with the target branch and resolve any conflicts
  • Answer the below questions to describe your PR for reviewers
  • Request at least two reviewers using the "Reviewers" section on the right, usually including at least one reviewer from your team
  • Notify the requested reviewers in the #code-review Slack channel once the PR is ready for review

Why are these changes needed?

Some of the components don't look right in mobile view and need updating.
Need to move 'Raw' data button inside Component if possible

What changed?

  • Add some bootstrap classes to help with styling components.
  • Move 'Raw' data button and its functionality inside the accordion.
  • Add 'rawOnClick' param to all components, allowing to pass its function from ResourceContainer.
  • Add example of aways visible and hidden 'raw' buttons to ResourceCategory.

How are these changes tested?

  • Tests are passing
  • Looking at components in mobile view mode

daria-lasecka and others added 3 commits April 7, 2022 10:08
@daria-lasecka
Update version number
a3ec6cc
@daria-lasecka
Fix components on mobile view (#353)
a2fdac1 
* Fix styles for mobile

* Fix padding

* Fix paddings, fix font size

* Fix alignment

* Add conditions because empty space is showing on mobile

* Add item alignment center
@daria-lasecka
[PATIENTAPP-139] Move the 'Raw' data button to inside the patient card (
1597edc 
#355)

* Add raw button styles, move raw button inside accordion if possible, add rawOnClick to components

* Add example of always visible raw button to resourceContainer

* Clean up imports

* Change component RecourceContainer to function
@glenn1uphealth glenn1uphealth merged commit f30f375 into main Apr 12, 2022
@glenn1uphealth glenn1uphealth deleted the release-0-3-9 branch April 12, 2022 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glenn1uphealth glenn1uphealth glenn1uphealth approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daria-lasecka @glenn1uphealth