-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reusable button component #25
Conversation
…various part in the project fix #10
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like how the PR is detailed and the button is working and it's reusable and i like how did you use the tailwind merge function so the others can override the default styling .
Keep up the good work👏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the detailed explanation Tewfik, such an amazing job.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work on the button components! The code is clean, follows our style guidelines, and promotes reusability. It's well-documented too. Just make sure to check for accessibility, and we're good to go.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The button is working and it's reusable.
Good job !👏
reusable button component
In this PR I did the following tasks :
I created a reusable button component added a default styling to it using Tailwind CSS and added a tailwind merge function to override the default style when needed.
I chose default styling for the most used components like sign in button
Screenshot
How to use the button
to use this component use the opening and closing tags add the title of the button you want to type
add your styling if you want to override the default styling for example:
to use the offer button in the navbar
fix #10
Related Issue