Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reusable button component #25

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Reusable button component #25

merged 1 commit into from
Oct 17, 2023

Conversation

Ben-Tewfik
Copy link
Contributor

@Ben-Tewfik Ben-Tewfik commented Oct 17, 2023

In this PR I did the following tasks :

  • I created a reusable button component added a default styling to it using Tailwind CSS and added a tailwind merge function to override the default style when needed.

  • I chose default styling for the most used components like sign in button

Screenshot

image

How to use the button

to use this component use the opening and closing tags add the title of the button you want to type

image

add your styling if you want to override the default styling for example:

to use the offer button in the navbar
image

<Button className=' bg-[#585785] border-none text-white px-6 hover:bg-[#7874F2] hover:text-white rounded-[20px]'>
                    Offer
</Button>

fix #10

Related Issue

@Ben-Tewfik Ben-Tewfik linked an issue Oct 17, 2023 that may be closed by this pull request
4 tasks
@vercel
Copy link

vercel bot commented Oct 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
student-store ✅ Ready (Inspect) Visit Preview Oct 17, 2023 5:35pm

Copy link
Contributor

@hocine1212 hocine1212 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like how the PR is detailed and the button is working and it's reusable and i like how did you use the tailwind merge function so the others can override the default styling .
Keep up the good work👏

Copy link
Collaborator

@KatiaGhezali KatiaGhezali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the detailed explanation Tewfik, such an amazing job.

Copy link
Contributor

@khaoulasara khaoulasara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on the button components! The code is clean, follows our style guidelines, and promotes reusability. It's well-documented too. Just make sure to check for accessibility, and we're good to go.

Copy link
Contributor

@samiba6 samiba6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The button is working and it's reusable.
Good job !👏

@Ben-Tewfik Ben-Tewfik changed the title feat(button component): create a reusable button component to use in … reusable button component Oct 17, 2023
@Ben-Tewfik Ben-Tewfik changed the title reusable button component Reusable button component Oct 17, 2023
@Ben-Tewfik Ben-Tewfik merged commit 7c8ca05 into develop Oct 17, 2023
6 checks passed
@khaoulasara khaoulasara self-requested a review October 17, 2023 19:22
@Ben-Tewfik Ben-Tewfik deleted the 10-buttons branch October 17, 2023 19:22
KatiaGhezali pushed a commit that referenced this pull request Oct 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component component enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Button Component
5 participants