Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Underbar component #26

Merged
merged 2 commits into from
Oct 18, 2023
Merged

Underbar component #26

merged 2 commits into from
Oct 18, 2023

Conversation

Ben-Tewfik
Copy link
Contributor

@Ben-Tewfik Ben-Tewfik commented Oct 18, 2023

Tast Description
In this pull request, I created an underbar component to use in the website's navbar to display product categories. This underbar provides easy navigation for users to access different product categories available on the website.

Styling
for the styling, the underbar is responsive on the desktop screen
image
and the tablet screen
image
for the mobile screen, I kept it as it is to modify it later when we added it to the navbar
image

Code
I created an ul inside a div and put each category inside a link I kept the href of the link empty to add later when the products page is ready
I put the ul inside a div added a tailwind-merge function and passed a className as a second argument to the function if later we want to alter the display of the underbar in mobile size we can pass the style as a prop for example if we want to change the background in the mobile size we added a prop and it will override the default style

<UnderBar className={'sm:bg-red-300'}/>

image

Related Issue

@Ben-Tewfik Ben-Tewfik linked an issue Oct 18, 2023 that may be closed by this pull request
3 tasks
@vercel
Copy link

vercel bot commented Oct 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
student-store ✅ Ready (Inspect) Visit Preview Oct 18, 2023 8:05pm

Copy link
Contributor

@khaoulasara khaoulasara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the code thoroughly, and it looks solid. The underbars categories implementation seems well-structured and efficient. No glaring issues, and it integrates seamlessly with our existing codebase. Good job addressing the technical aspects.

Copy link
Collaborator

@KatiaGhezali KatiaGhezali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took a look at it, and it is well done 👏

@KatiaGhezali KatiaGhezali merged commit 8b01dc0 into develop Oct 18, 2023
6 checks passed
@Ben-Tewfik Ben-Tewfik deleted the 16-underbar branch October 18, 2023 20:59
KatiaGhezali added a commit that referenced this pull request Oct 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component component enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UnderBar
3 participants