-
Notifications
You must be signed in to change notification settings - Fork 1
[PR]: [chore] development team, build id - config 설정 #87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @sophia22001, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! 이 풀 리퀘스트는 iOS 개발 환경 설정을 간소화하고, 토큰 재발급 로직의 안정성을 향상시키며, 사용자 인터페이스의 일부를 개선하는 데 중점을 둡니다. Xcode 빌드 설정을 Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
이 PR은 Xcode 개발 팀 및 번들 식별자 설정을 xcconfig 파일로 분리하여 개발 편의성을 높였습니다. 또한, 토큰 재발급 시 무한 루프를 방지하기 위해 인터셉터가 없는 Axios 인스턴스를 도입하고 관련 로직을 개선했습니다. UI 측면에서는 툴팁 컴포넌트의 스타일이 변경되었고, 일부 섹션에서 툴팁 기능이 이동 및 제거되었습니다. 전반적으로 기능 개선과 개발 환경 설정에 중점을 둔 변경사항입니다.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR aims to streamline iOS development by configuring Xcode build settings through .xcconfig files to avoid manual setup of Development Team and Build Identifier for each developer. However, the PR includes several unrelated code changes that appear to be from concurrent development work, including authentication flow improvements, UI tooltip implementations, and dependency updates.
Key changes in this PR:
- Xcode configuration file setup for developer-specific build settings (though with implementation issues)
- Token reissue infinite loop fix by introducing a non-interceptor axios instance
- UI improvements including tooltip additions and styling corrections
Reviewed changes
Copilot reviewed 12 out of 15 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
.gitignore |
Adds entry for developer-specific xcconfig file (incorrect path) |
ios/Develop.xcconfig |
New configuration file with hardcoded team ID and bundle identifier |
ios/Offnal.xcodeproj/project.pbxproj |
Updates Xcode project to use xcconfig and adds debug shell script |
ios/Podfile.lock |
Updates several pod dependencies to newer versions |
src/infrastructure/remote/api/noInterceptorAxiosInstance.ts |
Creates new axios instance without interceptors |
src/infrastructure/remote/api/AuthService.ts |
Refactors token reissue with helper method and no-interceptor variant |
src/infrastructure/remote/api/axiosInstance.ts |
Adds debug comment for logging full request URL |
src/store/useAuthStore.ts |
Switches to no-interceptor API for token reissue to prevent infinite loop |
src/presentation/splash/SplashScreen.tsx |
Changes state access pattern and adds debug logging |
src/presentation/main/ui/RecommendMealSection.tsx |
Adds tooltip feature and fixes CSS class name |
src/presentation/main/ui/HealthGuideSection.tsx |
Removes tooltip implementation and fixes CSS class name |
src/presentation/main/components/Tooltip.tsx |
Redesigns tooltip positioning and styling |
src/presentation/main/components/HomeWorkTypeChip.tsx |
Comments out alarm time section and adjusts layout |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
🔗 관련 이슈 (Related Issue):
✍️ 변경 내용 (Description):
개발/리뷰할 때마다 Development Team과 Build Identifier을 Xcode에서 매번 설정해야 하는 번거로움이 있습니다. 이를 위해 이 Id들을 config로 설정했습니다.
🛠️ 작업 내용 상세 (Detailed Changes):
수행된 작업들을 세분화하여 목록 형태로 나열해주세요.
🧪 테스트 방법 (How to Test):
이 PR의 변경 사항이 올바르게 작동하는지 확인하기 위한 테스트 방법을 구체적으로 설명해주세요.
Develop.xcconfig 파일을 생성하는 법: New File -> File From Template -> Configuration Settings File -> 이름 쓰고, target까지 체크

✅ 체크리스트 (Checklist):
PR을 올리기 전 아래 항목들을 확인해주세요.
main브랜치에 직접 푸시하지 않았나요?package.json또는build.gradle등을 업데이트했나요?