Cleanup unlisted_choice experiment - now available for all #3263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merging this PR will trigger the following deployment actions. Support and Staging deployments
Production deployments
|
consideRatio
changed the title
yuvipanda
approved these changes
Oct 13, 2023
|
🎉🎉🎉🎉 Monitor the deployment of the hubs here 👉 https://github.com/2i2c-org/infrastructure/actions/runs/6506368868 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
unlisted_choiceexperiment may be considered complete. The feature is available in kubespawner 6.1, and we are using that version via z2jh 3.1 already.One could extend the life of the experiment as well to for example jupyterhub/kubespawner#778 have an image to test against this specifically. I opened this PR directly instead of an issue first, but its fine if someone prefers we close this PR.
I suggest that we clean this up and add it back if needed instead though, and then focused on the new functionality from jupyterhub/kubespawner#778 where unlisted_choice can be used without any other choices provided.