fix: reject on non-2xx HTTP responses in API service (\ bounty #1) - #27
Open
zhuyh1606-oss wants to merge 1 commit into
Open
fix: reject on non-2xx HTTP responses in API service (\ bounty #1)#27zhuyh1606-oss wants to merge 1 commit into
zhuyh1606-oss wants to merge 1 commit into
Conversation
- request<T>() now throws ApiError on non-2xx status instead of returning as successful ApiResponse<T> - parseErrorResponse extracts JSON/text error bodies into ApiError with code, message, details, requestId, and path - Error interceptors run for normalized HTTP errors (401, 429) - Timeout and network-error behavior preserved - Added API_VALIDATION.md documenting all error scenarios
Author
|
Hi maintainers, gentle bump on this PR. It adds proper error handling for non-2xx HTTP responses in the API service. Mergeable and ready for review whenever you have time. Thanks! |
Author
|
Hi @2lll5, just following up on this PR. It's been open for a while and is ready for merge. Could you please review and merge when you have time? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make the shared frontend API service properly reject non-2xx HTTP responses instead of returning them as successful ApiResponse<T>.
Changes
Testing