Skip to content

feat: add [--source ***] [--custom_path XXX] for run cmd #669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 7, 2024
Merged

feat: add [--source ***] [--custom_path XXX] for run cmd #669

merged 3 commits into from
Aug 7, 2024

Conversation

weedge
Copy link
Contributor

@weedge weedge commented Aug 6, 2024 •
edited
Loading

feat:

  • add [--source ***] [--custom_path XXX] for run cmd

@github-actions github-actions bot changed the base branch from main to dev August 6, 2024 07:27
fumiama
fumiama requested changes Aug 6, 2024
View reviewed changes
Copy link
Member

@fumiama fumiama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you agree with me, you can modify run.py and implement load_normalizer there, that's a good modification. Otherwise, you can close this PR.

@fumiama fumiama added the ui UI improvements & issues label Aug 6, 2024
@weedge
Copy link
Contributor Author

weedge commented Aug 6, 2024

@fumiama done

@weedge weedge changed the title feat: add simple_run example feat: add [--source ***] [--custom_path XXX] for run cmd Aug 6, 2024
fumiama
fumiama reviewed Aug 6, 2024
View reviewed changes
@fumiama fumiama added the enhancement New feature or request label Aug 6, 2024
fumiama
fumiama approved these changes Aug 7, 2024
View reviewed changes
Copy link
Member

@fumiama fumiama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fumiama fumiama merged commit 6259319 into 2noise:dev Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fumiama fumiama fumiama approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request ui UI improvements & issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@weedge @fumiama