Fix/235 update test data #269
Conversation
…e into 235-update-test-data
There was a problem hiding this comment.
Besides my comments inline, it seems to me that the test data still contains lots of unused files. Is that so?
Other thing I noticed is that make test + make test_integration succeeds, but make test_all fails at the test_party_walls test with an error that the partition 0/0/0 does not exist. I don't know why is this happening, but it suggests that there is still some mismatch between the test configuration and the test files.
| if env == "test": | ||
| root_dir = Path(os.getenv("BAG3D_FILESTORE")) / "reconstruction_input" | ||
| root_dir = ( | ||
| Path(os.getenv("BAG3D_FILESTORE")) / "integration_party_walls/file_store" |
There was a problem hiding this comment.
Why did you change this? Why set to "integration_party_walls/file_store"?
There was a problem hiding this comment.
It is not nested, for each integration test I have a filestore and a filestore_fastssd, so that it is clear (like we havei n production)
…peline into fix/235--update-test-data
No description provided.