Skip to content

not storing metadata for tiles without hash matched #278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

not storing metadata for tiles without hash matched #278

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9a7166c
not storing metadata for tiles without hash matched
GinaStavropoulou Aug 18, 2025
53aae7c
merged develop
GinaStavropoulou Aug 19, 2025
88e8597
Merge branch 'develop' of github.com:3DBAG/3dbag-pipeline into ahn5-p…
GinaStavropoulou Aug 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 21 additions & 6 deletions packages/core/src/bag3d/core/assets/ahn/download.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,11 @@ def laz_files_ahn3(context, config: LazFilesConfig, md5_ahn3, tile_index_ahn):

# Let's try to re-download the file once
if not first_validation:
logger.info(format_laz_log(fpath, "Removing"))
logger.info(
format_laz_log(
fpath, "First validation failed. Removing and retrying..."
)
)
fpath.unlink()
lazdownload = download_ahn_laz(
fpath=fpath, url_laz=url_laz, verify_ssl=verify_ssl
Expand All @@ -198,7 +202,7 @@ def laz_files_ahn3(context, config: LazFilesConfig, md5_ahn3, tile_index_ahn):
if not second_validation:
logger.warning(format_laz_log(fpath, "Checksum failed"))
else:
logger.debug(format_laz_log(fpath, "OK"))
logger.debug(format_laz_log(fpath, "Validation OK"))

return Output(lazdownload, metadata=lazdownload.asdict())

Expand Down Expand Up @@ -237,7 +241,11 @@ def laz_files_ahn4(context, config: LazFilesConfig, md5_ahn4, tile_index_ahn):

# Let's try to re-download the file once
if not first_validation:
logger.info(format_laz_log(fpath, "Removing"))
logger.info(
format_laz_log(
fpath, "First validation failed. Removing and retrying..."
)
)
fpath.unlink()
lazdownload = download_ahn_laz(
fpath=fpath,
Expand All @@ -250,7 +258,7 @@ def laz_files_ahn4(context, config: LazFilesConfig, md5_ahn4, tile_index_ahn):
if not second_validation:
logger.warning(format_laz_log(fpath, "Checksum failed"))
else:
logger.debug(format_laz_log(fpath, "OK"))
logger.debug(format_laz_log(fpath, "Validation OK"))

return Output(lazdownload, metadata=lazdownload.asdict())

Expand Down Expand Up @@ -286,7 +294,11 @@ def laz_files_ahn5(context, config: LazFilesConfig, sha256_ahn5, tile_index_ahn)
)
# Let's try to re-download the file once
if not first_validation:
logger.info(format_laz_log(fpath, "Removing"))
logger.info(
format_laz_log(
fpath, "First validation failed. Removing and retrying..."
)
)
fpath.unlink()
lazdownload = download_ahn_laz(
fpath=fpath,
Expand All @@ -299,7 +311,7 @@ def laz_files_ahn5(context, config: LazFilesConfig, sha256_ahn5, tile_index_ahn)
if not second_validation:
logger.warning(format_laz_log(fpath, "Checksum failed"))
else:
logger.debug(format_laz_log(fpath, "OK"))
logger.debug(format_laz_log(fpath, "Validation OK"))

return Output(lazdownload, metadata=lazdownload.asdict())

Expand Down Expand Up @@ -370,6 +382,9 @@ def download_ahn_laz(
)
else: # pragma: no cover
logger.info(format_laz_log(fpath, "File already downloaded"))
success = True
file_size = round(fpath.stat().st_size / 1e6, 2)
is_new = False
if force_download:
logger.info(format_laz_log(fpath, "Forcing re-download"))
file_size, fpath, is_new, success, url_laz = download_laz(
Expand Down
7 changes: 7 additions & 0 deletions packages/core/src/bag3d/core/assets/ahn/metadata.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,6 +200,13 @@ def compute_load_metadata(
"""
tile_id = context.partition_key
conn = context.resources.db_connection.connect
if not laz_files_ahn.success or laz_files_ahn.hash_name is None:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The filtering I mentioned above

context.log.info(
f"LAZ tile {tile_id} has not been successfully downloaded."
f"Skipping metadata computation..."
)
return Output(None)

if not laz_files_ahn.new:
if not context.op_execution_context.op_execution_context.op_config["force"]:
context.log.info(
Expand Down
Loading