contrib-nested-django-apps, mapping migration files from nested django apps #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bmodule this feature requires an opt-in flag, named --resolve-nested-apps. enabling this flag will attempt to map migration files to django.apps.apps.app_configs by using both's relative path to self.django_path (or settings.BASE_DIR). if the app_config's relative path matches the migration files's parent folder's relative path, that is considered a match and the migration is associated with the app_config.label for later lookups.
|
ref #246 |
|
PS, after this is closed, the repo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
support migrations discovered within a submodule
this feature requires an opt-in flag, named --resolve-nested-apps. enabling this flag will attempt to map migration files to django.apps.apps.app_configs by using both's relative path to self.django_path (or settings.BASE_DIR). if the app_config's relative path matches the migration files's parent folder's relative path, that is considered a match and the migration is associated with the app_config.label for later lookups.
specifically, django-migration-linter presently assumes the app_config's label is going to be the foldername of the pymodule, which must be the django default when no AppConfig class provides a label. This pattern does not work for nested apps, it does not map migration files to app_labels correctly, meaning these app's and their migrations are skipped during linting.