Fix issue with gather migrations when app has custom defined label #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests are failing, I've setup local runner, I will reopen PR when ready to avoid triggering Actions here |
pirelle
commented
Aug 21, 2023
| @@ -105,7 +112,7 @@ def test_accept_adding_manytomany_field(self): | |||
| self._test_linter_finds_no_errors(app) | |||
|
|
|||
| def test_with_git_ref(self): | |||
| self._test_linter_finds_errors(commit_id="v0.1.4") | |||
| self._test_linter_finds_errors(commit_id=V014_REVISION) | |||
There was a problem hiding this comment.
Not sure why, but I had no labels in git when tests running, so changed it into revision number.
|
@David-Wobrock what do you think about the issue and PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for the issue #261