Don't consider partial unique index creation as making a column not nullable #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tests/unit/test_sql_analyser.py
Outdated
| @@ -308,6 +308,10 @@ def test_create_index_concurrently_where(self): | |||
| sql = 'CREATE INDEX CONCURRENTLY "index_name" ON "table_name" ("a_column") WHERE ("some_column" IS NOT NULL);' | |||
| self.assertValidSql(sql) | |||
|
|
|||
| def test_create_unique_index_concurrently_where(self): | |||
| sql = 'CREATE UNIQUE INDEX CONCURRENTLY "index_name" ON "table_name" ("a_column") WHERE ("some_column" IS NOT NULL);' | |||
| self.assertValidSql(sql) | |||
There was a problem hiding this comment.
Adding a unique index is considered backward incompatible 👀
See https://github.com/3YOURMIND/django-migration-linter/blob/main/docs/incompatibilities.md#arrow_forward-adding-a-unique-constraint
There was a problem hiding this comment.
good catch, I think tests should be updated now to assert that it's at least raising the uniqueness error and not the not null error
David-Wobrock
force-pushed
the
250-adding-a-unique-index-with-a-not-null-condition-incorrectly-triggers-not_null-rule
branch
from
427a2d2
to
3197651
Compare
David-Wobrock
force-pushed
the
250-adding-a-unique-index-with-a-not-null-condition-incorrectly-triggers-not_null-rule
branch
from
3197651
to
5b20f43
Compare
David-Wobrock
approved these changes
Mar 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One more fix related to #250: the current regex match only makes an exception for "CREATE INDEX" but not "CREATE UNIQUE INDEX", which is safe for the same reasons
Same idea as the fix in #258