Optionally do not reraise sqlmigrate exceptions #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kekekekule
force-pushed
the
flag-to-ignore-error-on-sqlmigrate
branch
from
a8c1f15
to
ac13fb3
Compare
|
Thanks! I'll take a look soonish :) |
|
@David-Wobrock I suppose the further step is to apply migrations right after linting them. This approach requires to change migration sorting in lint_all_migrations. This could solve problems like crash of sqlmigrate in case of changing unique constraints, for example. Wish I could implement this soonish. |
David-Wobrock
force-pushed
the
flag-to-ignore-error-on-sqlmigrate
branch
from
ac13fb3
to
72ccde4
Compare
David-Wobrock
approved these changes
Mar 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves: #274
Discussed this option in #273