-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor kotti pagination #543
base: master
Are you sure you want to change the base?
Commits on Oct 14, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 334ffd0 - Browse repository at this point
Copy the full SHA 334ffd0View commit details -
refactor(kottiPagination): add prop types, zod schema and add to expo…
…rted kotti types
Configuration menu - View commit details
-
Copy full SHA for e4e2db7 - Browse repository at this point
Copy the full SHA e4e2db7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4f94b34 - Browse repository at this point
Copy the full SHA 4f94b34View commit details -
Configuration menu - View commit details
-
Copy full SHA for 626eb99 - Browse repository at this point
Copy the full SHA 626eb99View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4c2314c - Browse repository at this point
Copy the full SHA 4c2314cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4f03cdb - Browse repository at this point
Copy the full SHA 4f03cdbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1420772 - Browse repository at this point
Copy the full SHA 1420772View commit details -
Configuration menu - View commit details
-
Copy full SHA for ce9772c - Browse repository at this point
Copy the full SHA ce9772cView commit details -
refact(kotti-pagination): inline function that calculates center of s…
…hown number array
Configuration menu - View commit details
-
Copy full SHA for 91598cb - Browse repository at this point
Copy the full SHA 91598cbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0e56ed5 - Browse repository at this point
Copy the full SHA 0e56ed5View commit details
Commits on Dec 1, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 56080c1 - Browse repository at this point
Copy the full SHA 56080c1View commit details
Commits on May 25, 2022
-
fix(KtComment): avatar gets squashed with large comments
the comment-wrapper had flex: 1 1 auto changing it to flex: 1 means that it became flex: 1 1 0 the flex-basis is the third property/value changing it to `0` means that the elements WON'T change size after the space is redistributed this guarantees that the comment_wrapper doesn't take more space, ...and therefore squash the avatar
Configuration menu - View commit details
-
Copy full SHA for bf9d4cb - Browse repository at this point
Copy the full SHA bf9d4cbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 802472e - Browse repository at this point
Copy the full SHA 802472eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1e85813 - Browse repository at this point
Copy the full SHA 1e85813View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0199166 - Browse repository at this point
Copy the full SHA 0199166View commit details -
fix(CommentActionsOptions): clickbehavior prop
rename CommentOptions -> CommentActionsOptions also, delete unnecessary imports / components of Kotti-registered components
Configuration menu - View commit details
-
Copy full SHA for fe9874a - Browse repository at this point
Copy the full SHA fe9874aView commit details -
feat(KtComment): implement CommentActions and CommentActionsReply
Common helper components for KtComment.vue and CommentReply.vue ..that wrap and unify the reply button / more actions button Product-approved Design and Request
Configuration menu - View commit details
-
Copy full SHA for 2f96173 - Browse repository at this point
Copy the full SHA 2f96173View commit details -
refact(CommentReply): move classes from _comments.scss
remove dead classes after the unification of reply button
Configuration menu - View commit details
-
Copy full SHA for 83c0ee2 - Browse repository at this point
Copy the full SHA 83c0ee2View commit details -
feat(KtCommentInput): prefix classes with
kt-
move styles to component (from _comments.scss) fix margin bottom for inline (try it with a comment below a reply) ..previously it looked ugly removed dead comment-input__button style
Configuration menu - View commit details
-
Copy full SHA for 1c453d8 - Browse repository at this point
Copy the full SHA 1c453d8View commit details -
feat(KtComment): prefix classes with
kt-
remove the now dead classes of `comment__action` and `comment-reply__action` ..replaced by components for the actions move ktComment styles to dedicated component instead of _comments.scss
Configuration menu - View commit details
-
Copy full SHA for e144bc5 - Browse repository at this point
Copy the full SHA e144bc5View commit details -
fix(KtComment): fix editing of replies
previously, editing was internally mutating the replies if the user edited the comment twice in a row, the old comment was brought ..back, since the internal initial value was not updated now editing the replies is controlled by the user app ktcomment exposes an event `editReplies` implemented CommentInlineEdit.vue and used it in CommentReply more refactoring will be done
Configuration menu - View commit details
-
Copy full SHA for ee74729 - Browse repository at this point
Copy the full SHA ee74729View commit details -
Configuration menu - View commit details
-
Copy full SHA for 134d42b - Browse repository at this point
Copy the full SHA 134d42bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9d09175 - Browse repository at this point
Copy the full SHA 9d09175View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3f1bb38 - Browse repository at this point
Copy the full SHA 3f1bb38View commit details -
Configuration menu - View commit details
-
Copy full SHA for eaab11e - Browse repository at this point
Copy the full SHA eaab11eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0c29297 - Browse repository at this point
Copy the full SHA 0c29297View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0ed4bab - Browse repository at this point
Copy the full SHA 0ed4babView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1dd00e5 - Browse repository at this point
Copy the full SHA 1dd00e5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6a9114c - Browse repository at this point
Copy the full SHA 6a9114cView commit details -
refact(CommentReply) use css variables
fix translations as well Co-Authored-By: Santiago Balladares <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for c5bcff2 - Browse repository at this point
Copy the full SHA c5bcff2View commit details -
Revert "refact(CommentReply) use css variables fix translations as well"
This reverts commit c5bcff2.
Configuration menu - View commit details
-
Copy full SHA for 9ca48f6 - Browse repository at this point
Copy the full SHA 9ca48f6View commit details -
Configuration menu - View commit details
-
Copy full SHA for a2e0482 - Browse repository at this point
Copy the full SHA a2e0482View commit details -
Revert "feat(KtComment): parse \n by default in post parser"
This reverts commit 1dd00e5.
Configuration menu - View commit details
-
Copy full SHA for a819a6b - Browse repository at this point
Copy the full SHA a819a6bView commit details -
Revert "enhance(CommentInlineEdit): scrollbar styles"
This reverts commit 0ed4bab.
Configuration menu - View commit details
-
Copy full SHA for 9b3f631 - Browse repository at this point
Copy the full SHA 9b3f631View commit details -
Revert "fix(KtPopover): not sure why we even need min width"
This reverts commit 0c29297.
Configuration menu - View commit details
-
Copy full SHA for 01c63f5 - Browse repository at this point
Copy the full SHA 01c63f5View commit details -
Revert "refact(KtComment): unified edit event - similar to delete"
This reverts commit eaab11e.
Configuration menu - View commit details
-
Copy full SHA for df90dc9 - Browse repository at this point
Copy the full SHA df90dc9View commit details -
Revert "fix(CommentInlineEdit): fix font-size and remove dead css"
This reverts commit 3f1bb38.
Configuration menu - View commit details
-
Copy full SHA for 4fb1a21 - Browse repository at this point
Copy the full SHA 4fb1a21View commit details -
Revert "fix(CommentReply): fix props passed to it and add types"
This reverts commit 9d09175.
Configuration menu - View commit details
-
Copy full SHA for b371b32 - Browse repository at this point
Copy the full SHA b371b32View commit details -
Revert "refact(KtComment): use CommentInlineEdit"
This reverts commit 134d42b.
Configuration menu - View commit details
-
Copy full SHA for 6340853 - Browse repository at this point
Copy the full SHA 6340853View commit details -
Revert "fix(KtComment): fix editing of replies previously, editing wa…
…s internally mutating the replies" This reverts commit ee74729.
Configuration menu - View commit details
-
Copy full SHA for ffcaf5e - Browse repository at this point
Copy the full SHA ffcaf5eView commit details -
Revert "feat(KtComment): prefix classes with
kt-
"This reverts commit e144bc5.
Configuration menu - View commit details
-
Copy full SHA for 6f0097b - Browse repository at this point
Copy the full SHA 6f0097bView commit details -
Revert "feat(KtCommentInput): prefix classes with
kt-
move styles t……o component (from _comments.scss)" This reverts commit 1c453d8.
Configuration menu - View commit details
-
Copy full SHA for f030c79 - Browse repository at this point
Copy the full SHA f030c79View commit details -
Revert "refact(CommentReply): move classes from _comments.scss remove…
… dead classes after the unification of reply button" This reverts commit 83c0ee2.
Configuration menu - View commit details
-
Copy full SHA for 9e68054 - Browse repository at this point
Copy the full SHA 9e68054View commit details -
Revert "feat(KtComment): implement CommentActions and CommentActionsR…
…eply" This reverts commit 2f96173.
Configuration menu - View commit details
-
Copy full SHA for 65ed5e2 - Browse repository at this point
Copy the full SHA 65ed5e2View commit details -
Revert "fix(CommentActionsOptions): clickbehavior prop rename Comment…
…Options -> CommentActionsOptions also, delete unnecessary imports / components of Kotti-registered components" This reverts commit fe9874a.
Configuration menu - View commit details
-
Copy full SHA for d9c02ae - Browse repository at this point
Copy the full SHA d9c02aeView commit details -
Revert "feat(KtComment): add CommentOptions component"
This reverts commit 0199166.
Configuration menu - View commit details
-
Copy full SHA for a317690 - Browse repository at this point
Copy the full SHA a317690View commit details -
Revert "feat(KtComment): add translations to edit and delete"
This reverts commit 1e85813.
Configuration menu - View commit details
-
Copy full SHA for f7b4e64 - Browse repository at this point
Copy the full SHA f7b4e64View commit details -
Revert "refact(KtComment): move classes around w/o changes"
This reverts commit 802472e.
Configuration menu - View commit details
-
Copy full SHA for 5561c18 - Browse repository at this point
Copy the full SHA 5561c18View commit details -
Revert "fix(KtComment): avatar gets squashed with large comments the …
…comment-wrapper had flex: 1 1 auto changing it to flex: 1 means that it became flex: 1 1 0 the flex-basis is the third property/value changing it to `0` means that the elements WON'T change size after the space is redistributed this guarantees that the comment_wrapper doesn't take more space, ...and therefore squash the avatar" This reverts commit bf9d4cb.
Configuration menu - View commit details
-
Copy full SHA for 8016a80 - Browse repository at this point
Copy the full SHA 8016a80View commit details