Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor kotti pagination #543

Open
wants to merge 49 commits into
base: master
Choose a base branch
from
Open

Commits on Oct 14, 2021

  1. Configuration menu
    Copy the full SHA
    334ffd0 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e4e2db7 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    4f94b34 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    626eb99 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    4c2314c View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    4f03cdb View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    1420772 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    ce9772c View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    91598cb View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    0e56ed5 View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2021

  1. Configuration menu
    Copy the full SHA
    56080c1 View commit details
    Browse the repository at this point in the history

Commits on May 25, 2022

  1. fix(KtComment): avatar gets squashed with large comments

    the comment-wrapper had flex: 1 1 auto
    changing it to flex: 1 means that it became flex: 1 1 0
    the flex-basis is the third property/value
    changing it to `0` means that the elements WON'T change size
    after the space is redistributed
    this guarantees that the comment_wrapper doesn't take more space,
    ...and therefore squash the avatar
    carsoli committed May 25, 2022
    Configuration menu
    Copy the full SHA
    bf9d4cb View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    802472e View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    1e85813 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    0199166 View commit details
    Browse the repository at this point in the history
  5. fix(CommentActionsOptions): clickbehavior prop

    rename CommentOptions -> CommentActionsOptions
    also, delete unnecessary imports / components of Kotti-registered components
    carsoli committed May 25, 2022
    Configuration menu
    Copy the full SHA
    fe9874a View commit details
    Browse the repository at this point in the history
  6. feat(KtComment): implement CommentActions and CommentActionsReply

    Common helper components for KtComment.vue and CommentReply.vue
    ..that wrap and unify the reply button / more actions button
    
    Product-approved Design and Request
    carsoli committed May 25, 2022
    Configuration menu
    Copy the full SHA
    2f96173 View commit details
    Browse the repository at this point in the history
  7. refact(CommentReply): move classes from _comments.scss

    remove dead classes after the unification of reply button
    carsoli committed May 25, 2022
    Configuration menu
    Copy the full SHA
    83c0ee2 View commit details
    Browse the repository at this point in the history
  8. feat(KtCommentInput): prefix classes with kt-

    move styles to component (from _comments.scss)
    
    fix margin bottom for inline (try it with a comment below a reply)
    ..previously it looked ugly
    
    removed dead comment-input__button style
    carsoli committed May 25, 2022
    Configuration menu
    Copy the full SHA
    1c453d8 View commit details
    Browse the repository at this point in the history
  9. feat(KtComment): prefix classes with kt-

    remove the now dead classes of `comment__action` and `comment-reply__action`
    ..replaced by components for the actions
    
    move ktComment styles to dedicated component instead of _comments.scss
    carsoli committed May 25, 2022
    Configuration menu
    Copy the full SHA
    e144bc5 View commit details
    Browse the repository at this point in the history
  10. fix(KtComment): fix editing of replies

    previously, editing was internally mutating the replies
    
    if the user edited the comment twice in a row, the old comment was brought
    ..back, since the internal initial value was not updated
    
    now editing the replies is controlled by the user app
    ktcomment exposes an event `editReplies`
    
    implemented CommentInlineEdit.vue and used it in CommentReply
    
    more refactoring will be done
    carsoli committed May 25, 2022
    Configuration menu
    Copy the full SHA
    ee74729 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    134d42b View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    9d09175 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    3f1bb38 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    eaab11e View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    0c29297 View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    0ed4bab View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    1dd00e5 View commit details
    Browse the repository at this point in the history
  18. chore(stylelint): fix

    carsoli committed May 25, 2022
    Configuration menu
    Copy the full SHA
    6a9114c View commit details
    Browse the repository at this point in the history
  19. refact(CommentReply) use css variables

    fix translations as well
    
    Co-Authored-By: Santiago Balladares <[email protected]>
    carsoli and santiagoballadares committed May 25, 2022
    Configuration menu
    Copy the full SHA
    c5bcff2 View commit details
    Browse the repository at this point in the history
  20. Configuration menu
    Copy the full SHA
    9ca48f6 View commit details
    Browse the repository at this point in the history
  21. Revert "chore(stylelint): fix"

    This reverts commit 6a9114c.
    carsoli committed May 25, 2022
    Configuration menu
    Copy the full SHA
    a2e0482 View commit details
    Browse the repository at this point in the history
  22. Revert "feat(KtComment): parse \n by default in post parser"

    This reverts commit 1dd00e5.
    carsoli committed May 25, 2022
    Configuration menu
    Copy the full SHA
    a819a6b View commit details
    Browse the repository at this point in the history
  23. Revert "enhance(CommentInlineEdit): scrollbar styles"

    This reverts commit 0ed4bab.
    carsoli committed May 25, 2022
    Configuration menu
    Copy the full SHA
    9b3f631 View commit details
    Browse the repository at this point in the history
  24. Revert "fix(KtPopover): not sure why we even need min width"

    This reverts commit 0c29297.
    carsoli committed May 25, 2022
    Configuration menu
    Copy the full SHA
    01c63f5 View commit details
    Browse the repository at this point in the history
  25. Configuration menu
    Copy the full SHA
    df90dc9 View commit details
    Browse the repository at this point in the history
  26. Configuration menu
    Copy the full SHA
    4fb1a21 View commit details
    Browse the repository at this point in the history
  27. Configuration menu
    Copy the full SHA
    b371b32 View commit details
    Browse the repository at this point in the history
  28. Revert "refact(KtComment): use CommentInlineEdit"

    This reverts commit 134d42b.
    carsoli committed May 25, 2022
    Configuration menu
    Copy the full SHA
    6340853 View commit details
    Browse the repository at this point in the history
  29. Revert "fix(KtComment): fix editing of replies previously, editing wa…

    …s internally mutating the replies"
    
    This reverts commit ee74729.
    carsoli committed May 25, 2022
    Configuration menu
    Copy the full SHA
    ffcaf5e View commit details
    Browse the repository at this point in the history
  30. Revert "feat(KtComment): prefix classes with kt-"

    This reverts commit e144bc5.
    carsoli committed May 25, 2022
    Configuration menu
    Copy the full SHA
    6f0097b View commit details
    Browse the repository at this point in the history
  31. Revert "feat(KtCommentInput): prefix classes with kt- move styles t…

    …o component (from _comments.scss)"
    
    This reverts commit 1c453d8.
    carsoli committed May 25, 2022
    Configuration menu
    Copy the full SHA
    f030c79 View commit details
    Browse the repository at this point in the history
  32. Revert "refact(CommentReply): move classes from _comments.scss remove…

    … dead classes after the unification of reply button"
    
    This reverts commit 83c0ee2.
    carsoli committed May 25, 2022
    Configuration menu
    Copy the full SHA
    9e68054 View commit details
    Browse the repository at this point in the history
  33. Revert "feat(KtComment): implement CommentActions and CommentActionsR…

    …eply"
    
    This reverts commit 2f96173.
    carsoli committed May 25, 2022
    Configuration menu
    Copy the full SHA
    65ed5e2 View commit details
    Browse the repository at this point in the history
  34. Revert "fix(CommentActionsOptions): clickbehavior prop rename Comment…

    …Options -> CommentActionsOptions also, delete unnecessary imports / components of Kotti-registered components"
    
    This reverts commit fe9874a.
    carsoli committed May 25, 2022
    Configuration menu
    Copy the full SHA
    d9c02ae View commit details
    Browse the repository at this point in the history
  35. Revert "feat(KtComment): add CommentOptions component"

    This reverts commit 0199166.
    carsoli committed May 25, 2022
    Configuration menu
    Copy the full SHA
    a317690 View commit details
    Browse the repository at this point in the history
  36. Revert "feat(KtComment): add translations to edit and delete"

    This reverts commit 1e85813.
    carsoli committed May 25, 2022
    Configuration menu
    Copy the full SHA
    f7b4e64 View commit details
    Browse the repository at this point in the history
  37. Revert "refact(KtComment): move classes around w/o changes"

    This reverts commit 802472e.
    carsoli committed May 25, 2022
    Configuration menu
    Copy the full SHA
    5561c18 View commit details
    Browse the repository at this point in the history
  38. Revert "fix(KtComment): avatar gets squashed with large comments the …

    …comment-wrapper had flex: 1 1 auto changing it to flex: 1 means that it became flex: 1 1 0 the flex-basis is the third property/value changing it to `0` means that the elements WON'T change size after the space is redistributed this guarantees that the comment_wrapper doesn't take more space, ...and therefore squash the avatar"
    
    This reverts commit bf9d4cb.
    carsoli committed May 25, 2022
    Configuration menu
    Copy the full SHA
    8016a80 View commit details
    Browse the repository at this point in the history