Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(KtField*Select): Remove Element-UI Entirely #565

Merged
merged 5 commits into from
May 31, 2022
Merged

fix(KtField*Select): Remove Element-UI Entirely #565

merged 5 commits into from
May 31, 2022

Commits on May 31, 2022

  1. fix(vetur): Use Strict Mode 

    Turns out that vetur only reads the top-level tsconfig
    @FlorianWendelborn @carsoli
    FlorianWendelborn authored and carsoli committed May 31, 2022
    Configuration menu
    Copy the full SHA
    7ca8071 View commit details
    Browse the repository at this point in the history

  2. refactor(KtFieldSelect): Remove Element UI 

    Co-Authored-By: Carol Soliman <[email protected]>
    @FlorianWendelborn @carsoli
    FlorianWendelborn and carsoli committed May 31, 2022
    Configuration menu
    Copy the full SHA
    ff2d61d View commit details
    Browse the repository at this point in the history

  3. improvement(documentation): Add Yoco Previews to leftIcon & rightIcon

    @FlorianWendelborn @carsoli
    FlorianWendelborn authored and carsoli committed May 31, 2022
    Configuration menu
    Copy the full SHA
    031ace0 View commit details
    Browse the repository at this point in the history

  4. feat(KtField*Select*): implement scroll-to behavior on keyboard navig… 

    …ation

..scroll to the option as you use keyboard (arrow down/up)

fix: show separator between options/no-data & actions
..even if options.length ===0 since no-data is still an item

fix: scrollbar for chrome
    @carsoli
    carsoli committed May 31, 2022
    Configuration menu
    Copy the full SHA
    271b005 View commit details
    Browse the repository at this point in the history

  5. fix(KtField*Select): implemented maximumSelectable properly 

    - disable the rest of the options on multi-select if maximumSelectable is reached
- feat: show `isUnsorted` prop on documentation
- fix: `isInputVisible` by moving the input out of screen instead
  - this is to properly support tabbing into (focus) when the dropdown is closed
  - we can't tab/focus into a field if there's no input
- fix: open the dropdown if the user starts typing into the field
  - in single selects, when user selects an option, the dropdown closes
  - the input still exists in the focused field yet the dropdown is closed
  - if the user starts typing, we open the dropdown again
  - it's an edge case that had weird UX previously
- fix: horizontal scrollbar UI

Co-Authored-By: Florian Wendelborn <[email protected]>
    @carsoli @FlorianWendelborn
    carsoli and FlorianWendelborn committed May 31, 2022
    Configuration menu
    Copy the full SHA
    54f1c82 View commit details
    Browse the repository at this point in the history