Skip to content

Migrate datatables from client to server side #5562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 45 commits into
base: master
Choose a base branch
from
Open

Migrate datatables from client to server side #5562

wants to merge 45 commits into from

Conversation

nboisteault
Copy link
Member

@nboisteault nboisteault commented Mar 18, 2025 •
edited by rldhont
Loading

Funded by digi-studio

lizmap-attributes-table-search

@github-actions github-actions bot added this to the 3.10.0 milestone Mar 18, 2025
@nboisteault nboisteault mentioned this pull request Mar 18, 2025
Closed
@nboisteault nboisteault force-pushed the datatables-server-side branch from c58903b to 96d8260 Compare March 18, 2025 16:34
rldhont
rldhont requested changes Mar 27, 2025
View reviewed changes
Copy link
Collaborator

@rldhont rldhont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To perform select to the top

@nboisteault nboisteault marked this pull request as ready for review March 28, 2025 14:33
@nboisteault nboisteault force-pushed the datatables-server-side branch 3 times, most recently from b328794 to fa9c547 Compare April 3, 2025 15:53
@nboisteault nboisteault force-pushed the datatables-server-side branch 2 times, most recently from 335794c to 9853b20 Compare April 15, 2025 08:53
@nboisteault nboisteault force-pushed the datatables-server-side branch 2 times, most recently from 8b20ff7 to 75dfb4a Compare April 22, 2025 14:54
@nboisteault nboisteault marked this pull request as draft April 22, 2025 15:10
@nboisteault nboisteault force-pushed the datatables-server-side branch 3 times, most recently from 3c4ed25 to 45a5b6f Compare April 25, 2025 15:08
@nboisteault nboisteault marked this pull request as ready for review May 6, 2025 16:22
@nboisteault nboisteault force-pushed the datatables-server-side branch 4 times, most recently from f2695f5 to 6137f63 Compare May 13, 2025 14:10
@Gustry Gustry mentioned this pull request May 20, 2025
Open
1 task
nboisteault and others added 29 commits September 26, 2025 17:20
@nboisteault @rldhont
Attribute table: add a toggle button to filter features in the curren…
8b8ac96 
…t extent
@nboisteault @rldhont
e2e: test data filtered by extent in attribute table
cabf5ba 
TODO: handle export
@nboisteault @rldhont
Attribute table: install Datatables v 2.2.2
843c7dc
@nboisteault @rldhont
Attribute table: update code for Datatables v2.2.2
2ac683e 
Legacy datatables is kept for admin part of Lizmap
@nboisteault @rldhont
Add Datataables searchBuilder
0e341e7
@nboisteault @rldhont
Add Datatables searchBuilder backend logic
975ecac
@nboisteault @rldhont
Returns editableFeatures in datatables request
3a6c442
@nboisteault @rldhont
e2e: migrate tests for DT2
2dfa7c0
@nboisteault @rldhont
Refresh tables afetr edition
b0d66be
@nboisteault @rldhont
e2e: update tests for DT2
8987ee9
@nboisteault @rldhont
Some fixes to pass playwright tests
a63e668
@nboisteault @rldhont
e2e: update key_value_mapping test to wait for datatables to be loaded
996ddbd
@nboisteault @rldhont
Update DT tables when filters change
6e30498
@nboisteault @rldhont
Use active and not btn-primary class for filter and select button…
96c2ec3 
…s in FeatureToolbar
@nboisteault @rldhont
Fix phpStan errors
3a1fd89
@nboisteault @rldhont
Datatables: update i18n and add deutsch
83a0721
@nboisteault @rldhont
Move selected to top button can now be toggled and only display selec…
eaec0c1 
…tion
@nboisteault @rldhont
DT: set orderSequence to have DT 1.x behaviour
8ef1cf4 
https://datatables.net/reference/option/columns.orderSequence
@nboisteault @rldhont
e2e: fix some tests
3972441
@rldhont
Use active with btn-primary class for filter and select buttons i…
a0e9ebc 
…n FeatureToolbar
@rldhont
DataTables request: send error and tests
d688628
@rldhont
Tests requests DataTables: bbox filter
0ba082b
@rldhont
Fix and test request DataTables order
04857d8
@rldhont
Define \Lizmap\DataTables\DataTables with static method to convert DT…
3f35b59 
…SearchBuilder to expression.
@rldhont
DataTables: manage invalid criteria
50f5d6e 
It is possible to send invalid criteria (not complete), in this case an empty expression is returned.
@rldhont
Tests requests DataTables: Pages
e88d33e
@rldhont
Tests requests DataTables: Filter featureIds
2b52414
@rldhont
DataTables fix recordsTotal and recordsFiltered type to int
74b97bd
@rldhont
Tests requests DataTables: fix features type
b98277c
@rldhont rldhont force-pushed the datatables-server-side branch from 6e21301 to b98277c Compare September 26, 2025 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rldhont rldhont rldhont requested changes

@mdouchin mdouchin Awaiting requested review from mdouchin

Assignees
No one assigned
Labels
attribute table backport release_3_10 new feature sponsored development This development has been funded
Projects
None yet
Milestone
3.11.0
Development

Successfully merging this pull request may close these issues.
3 participants
@nboisteault @rldhont @Gustry