Skip to content

Fix edition for column with strange characters #5654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 3 commits into
base: release_3_9
Choose a base branch
from
Draft

Fix edition for column with strange characters #5654

wants to merge 3 commits into from

Conversation

nworr
Copy link
Contributor

@nworr nworr commented Apr 25, 2025

Fix #5651

@github-actions github-actions bot added this to the 3.9.0 milestone Apr 25, 2025
@nworr nworr mentioned this pull request Apr 25, 2025
Open
1 task
@Gustry Gustry modified the milestones: 3.9.0, 3.9.1 Jun 19, 2025
@rldhont rldhont added backport master If the PR was against a release branch backport release_3_10 editing form labels Jun 24, 2025
mdouchin
mdouchin reviewed Jun 27, 2025
View reviewed changes
tests/qgis-projects/tests/tests_dataset.sql

CREATE TABLE tests_projects."BAD designed table" (
id integer NOT NULL,
"BAD column name is'nt it ?" integer NOT NULL,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😂

@Gustry
Copy link
Contributor

Gustry commented Jul 2, 2025

You should give a try to pre-commit, it will fix your issues automatically

@Gustry Gustry modified the milestones: 3.9.1, 3.9.2 Jul 15, 2025
@mdouchin mdouchin requested a review from rldhont August 25, 2025 09:51
@rldhont rldhont modified the milestones: 3.9.2, 3.9.3 Sep 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdouchin mdouchin mdouchin left review comments

@rldhont rldhont Awaiting requested review from rldhont

Assignees
No one assigned
Labels
backport master If the PR was against a release branch backport release_3_10 editing form
Projects
None yet
Milestone
3.9.3
Development

Successfully merging this pull request may close these issues.
4 participants
@nworr @Gustry @mdouchin @rldhont