PHP: Well deprecate lizmapProject class #5918
Conversation
| return $this->proj->checkAclByUser($login); | ||
| } | ||
| } | ||
| class lizmapProject extends Project {} |
There was a problem hiding this comment.
Same as in #5917, should we remove this code instead ?
Without a removing of the code in core LWC, the removing in other LWC modules will "likely" never happen because always postponed...
This code is deprecated since august 2020, so 5 years old.
Otherwise, we keep the code as it is with all "legacy" methods existing, but having a jLog deprecated warning on every call, so it will force modules to update "quickly" because of the noise in logging.
There was a problem hiding this comment.
There was a problem hiding this comment.
Here we can drop this class, because lizmap::getProject already returns \Lizmap\Project\Project
The lizmapProject class now extends \Lizmap\Project\Project.
rldhont
force-pushed
the
php-lizmapproject-deprecation
branch
from
d48fea8 to
95297a9
Compare
|
The Lizmap project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 2 months and is being automatically marked as "stale". |
The lizmapProject class now extends \Lizmap\Project\Project.