Skip to content

Provide default values for *very* old qgs files with missing attributes #6113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 7, 2025
Merged

Provide default values for *very* old qgs files with missing attributes #6113

merged 2 commits into from
Oct 7, 2025

Conversation

@nworr
Copy link
Contributor

@nworr nworr commented Sep 30, 2025 •
edited
Loading

Old qgs file ( < 3.10 i assume) does'nt contain saveDateTime in the xml project tag leading to a fatal error (see #6085)

the pr add default value (empty string) if value is null
add also mini refacto

Ticket : #6085

Funded by 3liz

@github-actions github-actions bot added this to the 3.11.0 milestone Sep 30, 2025
@nworr nworr changed the title feat : use null coalescing operator to ensure type Provide default values for *very* old qgs files with missing attributes Oct 3, 2025
@nworr nworr marked this pull request as ready for review October 3, 2025 13:38
rldhont
rldhont requested changes Oct 6, 2025
View reviewed changes
Copy link
Collaborator

@rldhont rldhont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update Qgis\ProjectInfo instead ?

@nworr nworr force-pushed the projet-no-save-date branch from 09a9b22 to 7446307 Compare October 6, 2025 08:58
rldhont
rldhont requested changes Oct 6, 2025
View reviewed changes
Copy link
Collaborator

@rldhont rldhont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the ProjectInfo docstring ?

 * @property null|string                               $saveDateTime
 * @property null|string                               $saveUser
 * @property null|string                               $saveUserFull

and the Qgis\ProjectProperties

@rldhont rldhont added the php Pull requests that update Php code label Oct 6, 2025
@rldhont
Copy link
Collaborator

rldhont commented Oct 6, 2025

Can you also add a test in tests/units/classes/Project/Qgis/ProjectInfoTest.php with tests/units/classes/Project/Ressources/WMSInfotest.qgs ?

@rldhont rldhont merged commit c5dad0c into 3liz:master Oct 7, 2025
17 of 18 checks passed
This was referenced Oct 7, 2025
Merged
Merged
@rldhont rldhont mentioned this pull request Oct 22, 2025
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rldhont rldhont rldhont approved these changes

Assignees

No one assigned

Labels

backport release_3_9 backport release_3_10 php Pull requests that update Php code

Projects

None yet

Milestone

3.11.0

Development

Successfully merging this pull request may close these issues.

2 participants

@nworr @rldhont