Fix support for MinnowBoard Turbot #9
Conversation
Signed-off-by: Piotr Król <[email protected]>
Signed-off-by: Piotr Król <[email protected]>
Signed-off-by: Piotr Król <[email protected]>
Signed-off-by: Piotr Król <[email protected]>
| @@ -1 +1 @@ | |||
| 1.2.1 | |||
| vUDK2017 | |||
There was a problem hiding this comment.
I assume we are starting with the very first tag of EDK2 and will gradually add support for newer versions? vUDK2017 is so old...
There was a problem hiding this comment.
@miczyg1 no, this would be economically not feasible. We adding what is needed, not necessarily in chronological order: https://github.com/3mdeb/edk2-docker/pull/9/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5R9
|
|
||
| [ ! -d edk2/CryptoPkg/Library/OpensslLib/openssl ] && git clone -b OpenSSL_1_1_0e https://github.com/openssl/openssl edk2/CryptoPkg/Library/OpensslLib/openssl | ||
|
|
||
| docker run --rm -it -w /home/edk2 -v $PWD/scripts:/home/edk2/scripts -v $PWD/edk2:/home/edk2/edk2 -v $PWD/edk2-platforms:/home/edk2/edk2-platforms -v $PWD/minnowboard_max-1.01-binary.objects:/home/edk2/silicon -v ${CCACHE_DIR:-$HOME/.ccache}:/home/edk2/.ccache 3mdeb/edk2:vUDK2017 bash /home/edk2/scripts/build_minnow.sh |
There was a problem hiding this comment.
This command asks for line breaks. Can we use \ to divide it into more lines for better readability?
|
@miczyg1 @pietrushnic any ideas what we should do with this PR? |
|
I guess we should address all discussions and merge. Of course this repo no longer make sense since there are upstream containers which we should rely on. |
Signed-off-by: Piotr Król [email protected]