Refactor mapping service #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lua-resty-iputils is already included in the base image
We are using the production image which should contains all required packages, hence reinstall packages with rover is unneeded.
tkan145
force-pushed
the
refactor-mapping-service
branch
from
3725cdb to
69e3969
Compare
roivaz
approved these changes
Mar 14, 2025
slopezz
approved these changes
Mar 14, 2025
slopezz
reviewed
Mar 14, 2025
There was a problem hiding this comment.
Thank you very much for the PR @tkan145 !!
Does the PR solves the issue detected in staging mapping-service (bad argument #2 to 'connect' (string expected, got table)?
If so, please remove the WIP from PR title, we will merge the PR and I will create a new image to test it in staging
|
@slopezz it should resolve the Removed WIP |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small refactor, including:
rover installwhen running busted test to avoid overwriting dependencies in the image with the image from Roverfile.lockThe only downside to this refactoring is that it will download the luarocks packages every time you run the busted test. But given the frequency of updates in this repository, I think we can live with that.