Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for telegram captions #1707

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lekoOwO
Copy link

@lekoOwO lekoOwO commented Feb 2, 2022

No description provided.

@codeclimate
Copy link

codeclimate bot commented Feb 2, 2022

Code Climate has analyzed commit ff0bc21 and detected 0 issues on this pull request.

View more on Code Climate.

@lekoOwO
Copy link
Author

lekoOwO commented Feb 2, 2022

I think this should be the real fix for #1649

@42wim 42wim added the telegram label Feb 2, 2022
@42wim
Copy link
Owner

42wim commented Feb 2, 2022

For #1649 it's actually the comment as can be seen in the debug log there
Do you have messages where it's the caption?

@lekoOwO
Copy link
Author

lekoOwO commented Feb 3, 2022

For #1649 it's actually the comment as can be seen in the debug log there
Do you have messages where it's the caption?

Oh I see.
For normal pictures like the one we send in group/supergroup/private chat, it should be captions.
Captions also applies to document, audio, video.... too.

@42wim
Copy link
Owner

42wim commented Feb 4, 2022

We already do this here: https://github.com/42wim/matterbridge/blob/master/bridge/telegram/handlers.go#L350
The caption gets set as a Comment and in receiving bridges this comment will be added to the text, see example for discord https://github.com/42wim/matterbridge/blob/master/bridge/discord/discord.go#L339

Where specifically are you not getting the captions? Could you paste a debug log?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants