Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optionally suppress URL embeds for Discord #1889

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Kufat
Copy link
Contributor

@Kufat Kufat commented Sep 5, 2022

No description provided.

@42wim 42wim added the discord label Sep 5, 2022
@42wim 42wim added this to the 1.26.0 milestone Sep 5, 2022
@42wim
Copy link
Owner

42wim commented Sep 6, 2022

So I've been thinking about this, and this seems like a tengo script can also solve.
My stance on adding new options to matterbridge is that if it can be done with a tengo script, it should be done that way.

Have you considered this as an option and it didn't work ? or maybe you didn't know about the scripting ?
More info on https://github.com/42wim/matterbridge/wiki/Tengo

@Kufat
Copy link
Contributor Author

Kufat commented Sep 7, 2022

I wasn't aware of the Tengo scripting feature, no.

It looks like Tengo scripts are global rather than per-gateway and don't have any access to the config, which wouldn't work for the use case needed on my network. (I'm sure I could bodge together something with various channel names and the desired behavior for each hardcoded, but that'd be inelegant.)

@42wim
Copy link
Owner

42wim commented Nov 26, 2022

@Kufat sorry for the late reply, you can match on the gateway in the tengo scripts, I think it should work?
Wrt access to the config, for this change you also need access to the config to enable it? It's the same as adding a script? or am I missing something ?

@codeclimate
Copy link

codeclimate bot commented Nov 26, 2022

Code Climate has analyzed commit f3f8b84 and detected 0 issues on this pull request.

View more on Code Climate.

@42wim 42wim removed this from the 1.26.0 milestone Jan 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants