Allow message deletes from any platform

[yousefmansy1]

Allow message deletes from any platform

This allows for message deletes to be synced from any of the gateway's channels, not just the "canonical"/source channel.

Note, the required changes in whatsappmulti handler depends on #1974
This is because when deleting a message that is not from the matterbridge user the sender jid is also required.

[yousefmansy1]

to be honest this is a bit of a hacky workaround and I don't necessarily like doing this pretty expensive operation on basically every message recived.

Hypothetically we can work around this

In practice this inefficiency would only matter in really large message caches (and we're mostly limited by I/O bandwidth).

I still don't really like it though.
I'd rather it be more of a graph-like structure where any message maps to the rest of the messages rather than 1 canonical message to the sent mesages.

[yousefmansy1]

This is less of an issue with the persistent message maps in #1996

[ilmaisin]

What this should exatly do and do not do? I have this PR applied in my instance, but cannot observe any propagation of message deletions between a Whatsapp and Telegram group.

Edit: And what the relation with #1986 is? Should I have that too applied for it to work?

[yousefmansy1]

What this should exatly do and do not do? I have this PR applied in my instance, but cannot observe any propagation of message deletions between a Whatsapp and Telegram group.

Edit: And what the relation with #1986 is? Should I have that too applied for it to work?

Yes you will have to have #1986 merged in as well as WhatsApp deletes wont propagate at all since those events are not handled.

(telegram APIs dont have events for any message deletes so that's also inevitable.)

In theory this should work as:

1. Message is sent from platform A
2. Message is deleted from platform B
3. Message is deleted on all platforms.

If you want to test this PR without merging #1986 as well
try sending a message from telegram to discord.
delete the message from discord, observe original message on telegram is deleted (make sure bot is admin)

[ilmaisin]

What this should exatly do and do not do? I have this PR applied in my instance, but cannot observe any propagation of message deletions between a Whatsapp and Telegram group.
Edit: And what the relation with #1986 is? Should I have that too applied for it to work?

Yes you will have to have #1986 merged in as well as WhatsApp deletes wont propagate at all since those events are not handled.

(telegram APIs dont have events for any message deletes so that's also inevitable.)

In theory this should work as:

1. Message is sent from platform A

2. Message is deleted from platform B

3. Message is deleted on all platforms.

If you want to test this PR without merging #1986 as well try sending a message from telegram to discord. delete the message from discord, observe original message on telegram is deleted (make sure bot is admin)

I merged that PR. When I delete a message sent by myself from Whastapp, something seems to appear according to log, but it doesn't get deleted from Telegram. My bot should be admin. How could I troubleshoot this?

[yousefmansy1]

I merged that PR. When I delete a message sent by myself from Whastapp, something seems to appear according to log, but it doesn't get deleted from Telegram. My bot should be admin. How could I troubleshoot this?

Hmm, can you share the log that you said appears?

Presumably if you send a message from WhatsApp, then delete it on WhatsApp, it will delete on telegram?

[yousefmansy1]

To expand, this CR is a relatively simple hack in which when it gets all the corresponding message IDs with a message those are only stored as a map from original ("canonical") message -> messages[]
there is a method that already existed will find the original message sent for any message.

In reality what we are doing is almost pretending the message delete came from the source platform (at least with regards to the message map.)

In #1996 I have two separate maps, one to store the mapping of message -> canonical message and another that does canonical message -> messages[]
We're getting O(1) complexity for some extra storage usage, in this case a worthy trade off as the data we're dealing with is quite light.
Does this matter in the long run? I don't know. But suppose you had a message history thousands long, it would start to bog down the system the longer you left it running.

[codeclimate]

Code Climate has analyzed commit 27c7b1e and detected 0 issues on this pull request.

View more on Code Climate.