Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Platform Agnostic Commands #1997

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

yousefmansy1
Copy link
Contributor

Add opt/in/out commands

Adds some commands that can be run regardless of the platform sent on (even works with DMs to the bot)

Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 8997 lines exceeds the maximum allowed for the inline comments feature.

Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 8998 lines exceeds the maximum allowed for the inline comments feature.

@42wim
Copy link
Owner

42wim commented Mar 10, 2023

If features can be done using Tengo script I'd rather have it done that way instead of adding extra features in matterbridge.
See https://github.com/42wim/matterbridge/wiki/Tengo

Ofcourse you can't use bbolt db, but if you really need state you can save it in a json file for example

Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 8998 lines exceeds the maximum allowed for the inline comments feature.

Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 8998 lines exceeds the maximum allowed for the inline comments feature.

(might not work for whatsapp if jid contains Agent and Device)
(Telegram and whatsapp for now)
@yousefmansy1 yousefmansy1 marked this pull request as draft March 15, 2023 09:20
Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 7428 lines exceeds the maximum allowed for the inline comments feature.

@yousefmansy1
Copy link
Contributor Author

yousefmansy1 commented Mar 15, 2023

@42wim this branch is a bit of a mess rn but to answer your question.
No, this cant be done with tango scripting.
Its much more than that.

Perhaps this is stretching past the intended usage of what matterbridge is meant to be.
But currently for my usage I'll be needing these features lol

- Add custom username
- Add custom avatar
- Fix help
- Add default avatar
Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 7627 lines exceeds the maximum allowed for the inline comments feature.

@codeclimate
Copy link

codeclimate bot commented Apr 4, 2023

Code Climate has analyzed commit 40ef694 and detected 10 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 3
Duplication 7

View more on Code Climate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants