Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

various improvements to attachment bridging #2172

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

various improvements to attachment bridging #2172

wants to merge 4 commits into from

Commits on Aug 16, 2024

  1. discord: put attachment URLs into Extra["file"] 

    previously, the urls were just appended to the message content.

i couldn't find any other assignments directly to Extra["file"]
anywhere in the codebase, so maybe there's a better way to do this.
    @ubq323
    ubq323 committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    ac2f7da View commit details
    Browse the repository at this point in the history

  2. xmpp: set body text to attachment URL in XEP-0066 OOB messages 

    many clients will only display files inline if the message body
itself exactly matches the attachment URL.

see https://docs.modernxmpp.org/client/protocol/#communicating-the-url
    @ubq323
    ubq323 committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    e168a89 View commit details
    Browse the repository at this point in the history

  3. discord: support sending files with just a URL 

    previously, the code assumed each file had a Data, and crashed if this was not present.
now, we detect this condition, and send the URL instead.

the discord client will display URLs in a message of their own
as inline embeds, without any special behavior needed on our part.

this commit makes the same changes to the webhook and non-webhook code.
    @ubq323
    ubq323 committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    707a74b View commit details
    Browse the repository at this point in the history

  4. irc: don't drop message body when sending attachment URLs

    @ubq323
    ubq323 committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    ce93d90 View commit details
    Browse the repository at this point in the history