Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:
- uses: actions/setup-node@1e60f620b9541d16bece96c5465dc8ee9832be0b
with:
node-version: lts/*
- uses: actions/cache@0c45773b623bea8c8e75f6c82b208c3cf94ea4f9
- uses: actions/cache@0400d5f644dc74513175e3cd8d07132dd4860809
name: Load Yarn cache
with:
path: ${{ steps.yarn-cache.outputs.dir }}
Expand Down
3 changes: 2 additions & 1 deletion jest.config.unit.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,6 @@
"coverageReporters": [["json", { "file": "coverage.unit.json" }]],
"preset": "ts-jest/presets/js-with-ts",
"testEnvironment": "node",
"testMatch": ["<rootDir>/src/*.test.[jt]s?(x)"]
"testMatch": ["<rootDir>/src/**/*.test.[jt]s?(x)"],
"testPathIgnorePatterns": ["<rootDir>/src/tests/"]
}
9 changes: 4 additions & 5 deletions src/generator/main.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,10 @@

import { generatorHandler } from '@prisma/generator-helper'
import fs from 'node:fs/promises'
import path from 'path/posix'
import { analyseDMMF } from '../dmmf'
import { generateIndex } from './generateIndex'
import { generateModel } from './generateModel'
import { getPrismaClientModule } from './prismaModule'

export interface Config {
concurrently?: boolean
Expand Down Expand Up @@ -43,11 +43,10 @@ generatorHandler({
const prismaClientOutput =
prismaClient.output?.value ?? 'node_modules/@prisma/client'

const prismaClientModule = prismaClientOutput.endsWith(
'node_modules/@prisma/client'
const prismaClientModule = getPrismaClientModule(
prismaClientOutput,
outputDir
)
? '@prisma/client'
: path.relative(outputDir, prismaClientOutput)

const longestModelNameLength = Object.keys(validModels).reduce(
(max, model) => Math.max(max, model.length),
Expand Down
41 changes: 41 additions & 0 deletions src/generator/prismaModule.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
import path from "path/posix";
import { getPrismaClientModule } from "./prismaModule";

describe("getPrismaClientModule", () => {
it('returns "@prisma/client" when prismaClientOutput ends with node_modules/@prisma/client (forward slashes)', () => {
const prismaClientOutput = "/some/project/node_modules/@prisma/client";
const outputDir = "/some/project/src";
expect(getPrismaClientModule(prismaClientOutput, outputDir)).toBe(
"@prisma/client"
);
});

it('returns "@prisma/client" when prismaClientOutput ends with node_modules\\@prisma\\client (backslashes)', () => {
const prismaClientOutput =
"C:\\some\\project\\node_modules\\@prisma\\client";
const outputDir = "C:\\some\\project\\src";
expect(getPrismaClientModule(prismaClientOutput, outputDir)).toBe(
"@prisma/client"
);
});

it("returns relative path with forward slashes if not in node_modules", () => {
const prismaClientOutput = "/some/project/generated/prisma-client";
const outputDir = "/some/project/src";
const expected = path
.relative(outputDir, prismaClientOutput)
.replace(/\\/g, "/");
expect(getPrismaClientModule(prismaClientOutput, outputDir)).toBe(expected);
});

it("returns relative path with forward slashes if not in node_modules (windows paths)", () => {
const prismaClientOutput = "C:\\some\\project\\generated\\prisma-client";
const outputDir = "C:\\some\\project\\src";
const expected = path
.relative(outputDir, prismaClientOutput)
.replace(/\\/g, "/");
expect(getPrismaClientModule(prismaClientOutput, outputDir)).toBe(expected);
});
});

// We recommend installing an extension to run jest tests.
19 changes: 19 additions & 0 deletions src/generator/prismaModule.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
import path from 'path/posix'

export function getPrismaClientModule(
prismaClientOutput: string,
outputDir: string
): string {
// Normalize to forward slashes for consistent detection and import path
const normalizedPrismaClientOutput = prismaClientOutput.replace(/\\/g, '/')
let prismaClientModule: string
if (normalizedPrismaClientOutput.endsWith('node_modules/@prisma/client')) {
prismaClientModule = '@prisma/client'
} else {
// Always use forward slashes in import paths
prismaClientModule = path
.relative(outputDir, prismaClientOutput)
.replace(/\\/g, '/')
}
return prismaClientModule
}
Loading