Open
Conversation
kronoker
changed the title
48x
reviewed
May 11, 2018
.idea/compiler.xml
Outdated
| @@ -0,0 +1,16 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
Owner
There was a problem hiding this comment.
Мусор от IDE и скомпилированный проект закидывать в репу - плохо и не надо.
| public void testThrowingExceptionIfItemsCountIsLessZero() { | ||
| Random random = new Random(); | ||
| try { | ||
| ClassToBeTested.generateIntSequence(random.nextInt(), -random.nextInt(Integer.MAX_VALUE) - 2); |
Owner
There was a problem hiding this comment.
Рандом + отрицание - усложение читабельности теста. Лучше обойтись без этого, тем более тут это можно легко сделать
| int min = Integer.MAX_VALUE / 2 + 1; | ||
| int max = Integer.MAX_VALUE; | ||
| int randomNumber1 = (int) (Math.random() * (max - min)) + min; | ||
| int randomNumber2 = (int) (Math.random() * (max - min)) + min; |
Owner
There was a problem hiding this comment.
Опять-таки, усложнение того, что можно было бы сделать намного проще и читабельнее.
48x
approved these changes
May 21, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.