fix: add pint call to enforce initialization of unit registry #1146

Czaki · 2024-07-15T10:13:32Z

Workaround for hgrecco/pint#2039

Summary by CodeRabbit

New Features
- Integrated pint library for unit management, improving flexibility and precision in handling measurements.

sourcery-ai · 2024-07-15T10:13:39Z

🧙 Sourcery has finished reviewing your pull request!

Tips

Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
Continue your discussion with Sourcery by replying directly to review comments.
You can change your review settings at any time by accessing your dashboard:
- Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
- Change the review language;
You can always contact us if you have any questions or feedback.

coderabbitai · 2024-07-15T10:13:46Z

Walkthrough

A new import statement for pint has been added to the base_settings.py file in the common_backend package. Additionally, a call to pint.get_application_registry() with the parameter "nm" has been included within the __init__ method of a class, enhancing the initialization process by integrating the unit registry from the pint library.

Changes

Files	Change Summary
`package/PartSeg/common_backend/base_settings.py`	Added an import statement for `pint` and a call to `pint.get_application_registry("nm")` in the `__init__` method of a class.

Poem

In code, where settings grow and gleam,
A unit registry, part of the dream.
With pint now in its rightful place,
Initialization finds its grace.
The backend sings a smoother tune,
As changes set the system to bloom.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

sourcery-ai

We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.

coderabbitai

Actionable comments posted: 1

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 733b168 and aa0742d.

Files selected for processing (1)

package/PartSeg/common_backend/base_settings.py (2 hunks)

Additional comments not posted (1)

package/PartSeg/common_backend/base_settings.py (1)

16-16: LGTM!

The import statement for pint is correctly placed.

coderabbitai · 2024-07-15T10:16:27Z

package/PartSeg/common_backend/base_settings.py

@@ -471,6 +472,7 @@ def __init__(self, json_path: Union[Path, str], profile_name: str = "default"):
        self.history_index = -1
        self.last_executed_algorithm = ""
        self._points = None
+        pint.get_application_registry()("nm")


Consider storing the result of the pint.get_application_registry("nm") call.

The call to pint.get_application_registry("nm") ensures the initialization of the unit registry. Consider storing the result in a variable for potential future use or for clarity.

- pint.get_application_registry()("nm") + registry = pint.get_application_registry("nm")

Committable suggestion was skipped due to low confidence.

sonarqubecloud · 2024-07-15T10:20:59Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

coderabbitai

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between aa0742d and 3e34b5d.

Files selected for processing (1)

package/PartSeg/common_backend/base_settings.py (2 hunks)

Files skipped from review as they are similar to previous changes (1)

package/PartSeg/common_backend/base_settings.py

codecov · 2024-07-15T10:28:51Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.01%. Comparing base (733b168) to head (3e34b5d).
Report is 57 commits behind head on develop.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #1146   +/-   ##
========================================
  Coverage    93.01%   93.01%           
========================================
  Files          207      207           
  Lines        32656    32658    +2     
========================================
+ Hits         30374    30376    +2     
  Misses        2282     2282

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

fix: add pint call to enforce initialization of unit registry

aa0742d

Czaki added this to the 0.15.4 milestone Jul 15, 2024

sourcery-ai bot reviewed Jul 15, 2024

View reviewed changes

coderabbitai bot reviewed Jul 15, 2024

View reviewed changes

add comment with explanation

3e34b5d

coderabbitai bot reviewed Jul 15, 2024

View reviewed changes

Czaki merged commit e13f990 into develop Jul 15, 2024
55 checks passed

Czaki deleted the fix_units_threads branch July 15, 2024 10:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: add pint call to enforce initialization of unit registry #1146

fix: add pint call to enforce initialization of unit registry #1146

Czaki commented Jul 15, 2024 •

edited by coderabbitai bot

Loading

sourcery-ai bot commented Jul 15, 2024 •

edited

Loading

coderabbitai bot commented Jul 15, 2024 •

edited

Loading

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

Documentation and Community

sourcery-ai bot left a comment

coderabbitai bot left a comment

coderabbitai bot Jul 15, 2024

sonarqubecloud bot commented Jul 15, 2024

coderabbitai bot left a comment

codecov bot commented Jul 15, 2024 •

edited

Loading

fix: add pint call to enforce initialization of unit registry #1146

fix: add pint call to enforce initialization of unit registry #1146

Conversation

Czaki commented Jul 15, 2024 • edited by coderabbitai bot Loading

Summary by CodeRabbit

sourcery-ai bot commented Jul 15, 2024 • edited Loading

coderabbitai bot commented Jul 15, 2024 • edited Loading

Walkthrough

Changes

Poem

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

Documentation and Community

sourcery-ai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot Jul 15, 2024

Choose a reason for hiding this comment

sonarqubecloud bot commented Jul 15, 2024

Quality Gate passed

coderabbitai bot left a comment

Choose a reason for hiding this comment

codecov bot commented Jul 15, 2024 • edited Loading

Codecov Report

Czaki commented Jul 15, 2024 •

edited by coderabbitai bot

Loading

sourcery-ai bot commented Jul 15, 2024 •

edited

Loading

coderabbitai bot commented Jul 15, 2024 •

edited

Loading

CodeRabbit Configration File (`.coderabbit.yaml`)

codecov bot commented Jul 15, 2024 •

edited

Loading