Skip to content

removed artifacts from copying from sklearn#100

Merged
4Freye merged 1 commit intomainfrom
remove_skartifacts
Dec 31, 2025
Merged

removed artifacts from copying from sklearn#100
4Freye merged 1 commit intomainfrom
remove_skartifacts

Conversation

@4Freye
Copy link
Owner

@4Freye 4Freye commented Dec 31, 2025

No description provided.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @4Freye, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request aims to refine the documentation within the panelsplit library by removing extraneous information inherited from sklearn. Specifically, it cleans up version history annotations and simplifies the detailed descriptions and examples for the cv_results_ attribute in the GridSearch and RandomizedSearch classes, making the documentation more focused and relevant to the current project.

Highlights

  • Documentation Cleanup: Removed sklearn-specific version history (.. versionadded::, .. versionchanged::) from docstrings in GridSearch and RandomizedSearch classes.
  • Docstring Simplification: Streamlined the documentation for the cv_results_ attribute in both GridSearch and RandomizedSearch by removing verbose examples and detailed notes.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request cleans up the docstrings in panelsplit/model_selection/model_selection.py by removing artifacts copied from scikit-learn. The changes involve deleting versionadded and versionchanged directives, as well as extensive examples for cv_results_ that are specific to scikit-learn's documentation. These changes are appropriate and make the documentation more relevant to the panelsplit library. The code looks good.

@4Freye 4Freye merged commit bb28b44 into main Dec 31, 2025
16 checks passed
@4Freye 4Freye deleted the remove_skartifacts branch December 31, 2025 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant