Skip to content

removed fallback versioning#98

Merged
4Freye merged 2 commits intomainfrom
dev_version
Dec 31, 2025
Merged

removed fallback versioning#98
4Freye merged 2 commits intomainfrom
dev_version

Conversation

@4Freye
Copy link
Owner

@4Freye 4Freye commented Dec 31, 2025

No description provided.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @4Freye, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the project's versioning mechanism by removing explicit write-to and fallback-version configurations from pyproject.toml and deleting the associated _version.py file. The project now exclusively uses Git tags for version derivation via hatch, leading to a cleaner and more consistent version management process.

Highlights

  • Versioning Configuration Streamlined: The write-to and fallback-version settings for hatch versioning have been removed from pyproject.toml. This change simplifies the versioning strategy, relying solely on Git tags (source = "vcs") for version derivation without writing to a dedicated file or providing a hardcoded fallback.
  • Redundant Version File Removed: The panelsplit/_version.py file, which previously contained a hardcoded version string and was managed by the write-to configuration, has been deleted as it is no longer necessary with the updated versioning approach.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the fallback versioning configuration from pyproject.toml and the associated _version.py file. While this simplifies the configuration, it introduces a critical issue where the package will fail to build from a source distribution (sdist), making it difficult for users and downstream packagers to use. My review includes a comment with a suggested fix to ensure the package remains buildable in all standard scenarios.

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@4Freye 4Freye merged commit 8824d63 into main Dec 31, 2025
14 checks passed
@4Freye 4Freye deleted the dev_version branch December 31, 2025 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant