Skip to content

added preloader for improved user experience#158

Merged
4darsh-Dev merged 2 commits into4darsh-Dev:mainfrom
Dharmi-dev:main
Jul 23, 2024
Merged

added preloader for improved user experience#158
4darsh-Dev merged 2 commits into4darsh-Dev:mainfrom
Dharmi-dev:main

Conversation

@Dharmi-dev
Copy link
Copy Markdown
Contributor

here i added the preloader for the CogniGuard, using index.html, style.css and script.js file

@github-actions github-actions Bot added the help wanted Extra attention is needed label Jul 22, 2024
@deepsource-io
Copy link
Copy Markdown
Contributor

deepsource-io Bot commented Jul 22, 2024

Here's the code health analysis summary for commits f829a80..e1ff015. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Shell LogoShell✅ SuccessView Check ↗
DeepSource JavaScript LogoJavaScript✅ SuccessView Check ↗
DeepSource Python LogoPython✅ SuccessView Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

Copy link
Copy Markdown
Owner

@4darsh-Dev 4darsh-Dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dharmi-dev
There are lot of issues, fix them first,
You haven't checked on your own device with project configurations,

Preview I am getting after checking :

Screenshot 2024-07-22 201640

});
});

window.addEventListener("load", myLoad);
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's a better approach to use useful function names like preLoad() or preLoadFunc()
instead of myload()

Comment thread django-web-app/static/css/style.css
@4darsh-Dev
Copy link
Copy Markdown
Owner

Take reference from the bugs i've fixed in this PR
solve-ease/community-website#35

Caution

You're repeating same mistakes again.

@4darsh-Dev 4darsh-Dev merged commit d7b8ece into 4darsh-Dev:main Jul 23, 2024
@4darsh-Dev
Copy link
Copy Markdown
Owner

GSSoC 24 has been completed Finally'
It was a great experience working with you all
Thanks💗 for your valuable contributions!
PA nomination has been started, Do fill out the forms soon. Share your experiences and let's connect on socials

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants