Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added preloader for improved user experience #158

Merged
merged 2 commits into from
Jul 23, 2024

Conversation

Dharmi-dev
Copy link
Contributor

here i added the preloader for the CogniGuard, using index.html, style.css and script.js file

@github-actions github-actions bot added the help wanted Extra attention is needed label Jul 22, 2024
Copy link
Contributor

deepsource-io bot commented Jul 22, 2024

Here's the code health analysis summary for commits f829a80..e1ff015. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Shell LogoShell✅ SuccessView Check ↗
DeepSource JavaScript LogoJavaScript✅ SuccessView Check ↗
DeepSource Python LogoPython✅ SuccessView Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

Copy link
Owner

@4darsh-Dev 4darsh-Dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dharmi-dev
There are lot of issues, fix them first,
You haven't checked on your own device with project configurations,

Preview I am getting after checking :

Screenshot 2024-07-22 201640

@@ -194,3 +194,12 @@ document.addEventListener('DOMContentLoaded', (event) => {
document.documentElement.scrollTop = 0; // For Chrome, Firefox, IE and Opera
});
});

window.addEventListener("load", myLoad);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's a better approach to use useful function names like preLoad() or preLoadFunc()
instead of myload()

@4darsh-Dev
Copy link
Owner

Take reference from the bugs i've fixed in this PR
solve-ease/community-website#35

Caution

You're repeating same mistakes again.

@4darsh-Dev 4darsh-Dev merged commit d7b8ece into 4darsh-Dev:main Jul 23, 2024
11 checks passed
@4darsh-Dev
Copy link
Owner

GSSoC 24 has been completed Finally'
It was a great experience working with you all
Thanks💗 for your valuable contributions!
PA nomination has been started, Do fill out the forms soon. Share your experiences and let's connect on socials

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants