-
-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added preloader for improved user experience #158
Conversation
Here's the code health analysis summary for commits Analysis Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Dharmi-dev
There are lot of issues, fix them first,
You haven't checked on your own device with project configurations,
Preview I am getting after checking :
@@ -194,3 +194,12 @@ document.addEventListener('DOMContentLoaded', (event) => { | |||
document.documentElement.scrollTop = 0; // For Chrome, Firefox, IE and Opera | |||
}); | |||
}); | |||
|
|||
window.addEventListener("load", myLoad); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's a better approach to use useful function names like preLoad() or preLoadFunc()
instead of myload()
Take reference from the bugs i've fixed in this PR Caution You're repeating same mistakes again. |
GSSoC 24 has been completed Finally' |
here i added the preloader for the CogniGuard, using index.html, style.css and script.js file