Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated testimonial cards in index.html #176

Merged
merged 2 commits into from
Aug 10, 2024
Merged

Conversation

Dharmi-dev
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the help wanted Extra attention is needed label Aug 10, 2024
Copy link
Contributor

deepsource-io bot commented Aug 10, 2024

Here's the code health analysis summary for commits cf4d21f..c1f9b3d. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Shell LogoShell✅ SuccessView Check ↗
DeepSource JavaScript LogoJavaScript✅ SuccessView Check ↗
DeepSource Python LogoPython✅ SuccessView Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@4darsh-Dev
Copy link
Owner

@Dharmi-dev you should add the description.

Copy link
Owner

@4darsh-Dev 4darsh-Dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dharmi-dev some issues are there.

@@ -121,8 +121,8 @@ <h2>CogniGuard reviews</h2>
<i class="fas fa-quote-left"></i>
<p>I love how CogniGuard educates me about dark patterns. The community aspect and reward points make it fun to contribute too!</p>
<div class="testimonial-author">
<img src="{% static 'img/sample-profile.png' %}" alt="Lance Jarvis">
<h3>User name</h3>
<img src="{% static 'https://media.licdn.com/dms/image/v2/D5603AQFz9vCras86Sw/profile-displayphoto-shrink_400_400/profile-displayphoto-shrink_400_400/0/1712070916942?e=1728518400&v=beta&t=ApYPKtnAgE1tgp9PBavhxehMXYMjMnS68Dn5VZa3HSs' %}" alt="Lance Jarvis">
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you haven't updated the alt tag, it must contain the username

<div class="testimonial-author">
<img src="{% static 'img/sample-profile.png' %}" alt="Ericka Lynda">
<h3>User name</h3>
<img src="{% static 'https://avatars.githubusercontent.com/u/148576891?v=4' %}" alt="Ericka Lynda">
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same mistake here as wel...

Copy link
Owner

@4darsh-Dev 4darsh-Dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fine

@4darsh-Dev 4darsh-Dev merged commit b924619 into 4darsh-Dev:main Aug 10, 2024
7 checks passed
@4darsh-Dev
Copy link
Owner

GSSoC 24 has been completed Finally'
It was a great experience working with you all
Thanks💗 for your valuable contributions!
PA nomination has been started, Do fill out the forms soon. Share your experiences and let's connect on socials

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants