Skip to content

Commit

Permalink
Add an item menu to add sub-folders in object folders (#6090)
Browse files Browse the repository at this point in the history
  • Loading branch information
D8H committed Dec 15, 2023
1 parent a1826d3 commit 9e5320f
Showing 1 changed file with 21 additions and 8 deletions.
29 changes: 21 additions & 8 deletions newIDE/app/src/ObjectsList/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -429,7 +429,7 @@ const ObjectsList = React.forwardRef<Props, ObjectsListInterface>(
);

const onAddNewObject = React.useCallback(
(item: ObjectFolderOrObjectWithContext) => {
(item: ObjectFolderOrObjectWithContext | null) => {
setNewObjectDialogOpen({ from: item });
},
[]
Expand Down Expand Up @@ -1165,13 +1165,13 @@ const ObjectsList = React.forwardRef<Props, ObjectsListInterface>(
);

const addFolder = React.useCallback(
() => {
(items: Array<ObjectFolderOrObjectWithContext>) => {
let newObjectFolderOrObjectWithContext;
if (selectedObjectFolderOrObjectsWithContext.length === 1) {
if (items.length === 1) {
const {
objectFolderOrObject: selectedObjectFolderOrObject,
global,
} = selectedObjectFolderOrObjectsWithContext[0];
} = items[0];
if (selectedObjectFolderOrObject.isFolder()) {
const newFolder = selectedObjectFolderOrObject.insertNewFolder(
'NewFolder',
Expand All @@ -1182,9 +1182,7 @@ const ObjectsList = React.forwardRef<Props, ObjectsListInterface>(
global,
};
if (treeViewRef.current) {
treeViewRef.current.openItems([
getTreeViewItemId(selectedObjectFolderOrObjectsWithContext[0]),
]);
treeViewRef.current.openItems([getTreeViewItemId(items[0])]);
}
} else {
const parentFolder = selectedObjectFolderOrObject.getParent();
Expand Down Expand Up @@ -1349,10 +1347,20 @@ const ObjectsList = React.forwardRef<Props, ObjectsListInterface>(
})
),
},
{ type: 'separator' },
{
label: i18n._(t`Add a new object`),
click: () => onAddNewObject(item),
},
{
label: i18n._(t`Add a new folder`),
click: () =>
addFolder(
selectedObjectFolderOrObjectsWithContext.includes(item)
? selectedObjectFolderOrObjectsWithContext
: [item]
),
},
{ type: 'separator' },
{
label: i18n._(t`Expand all sub folders`),
Expand Down Expand Up @@ -1563,7 +1571,12 @@ const ObjectsList = React.forwardRef<Props, ObjectsListInterface>(
/>
</Column>
<Column noMargin>
<IconButton size="small" onClick={addFolder}>
<IconButton
size="small"
onClick={() =>
addFolder(selectedObjectFolderOrObjectsWithContext)
}
>
<AddFolder />
</IconButton>
</Column>
Expand Down

0 comments on commit 9e5320f

Please sign in to comment.