Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce a lookup table for objects having modified local roles. #8086

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

elioschmutz
Copy link
Member

@elioschmutz elioschmutz commented Nov 14, 2024

This PR introduces a local roles tracking table which can be used to do ad-hoc reports about modified local-roles for users or objects.

The table stores all managed roles of each principal for each object having managed custom local roles.

For TI-1540

Checklist

Everything has to be done/checked. Checked but not present means the author deemed it unnecessary.

  • Changelog entry
  • Link to issue (Jira or GitHub) and backlink in issue (Jira)

Only applicable should be left and checked.

  • Upgrade-Steps:
    • SQL Operations do not use imported model (see docs)
    • DB-Schema migration
      • All changes on a model (columns, etc) are included in a DB-schema migration.
      • Constraint names are shorter than 30 characters (Oracle)

@elioschmutz elioschmutz marked this pull request as ready for review November 14, 2024 10:40
@elioschmutz elioschmutz requested review from a team and removed request for a team November 14, 2024 10:40
@elioschmutz elioschmutz force-pushed the es/TI-1540-local-roles-lookup-table branch 3 times, most recently from 1d83510 to 6ad0803 Compare November 15, 2024 07:56
Copy link
Member

@lukasgraf lukasgraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few comments, otherwise LGTM 👍

opengever/sharing/local_roles_modifications/manager.py Outdated Show resolved Hide resolved
opengever/sharing/local_roles_modifications/manager.py Outdated Show resolved Hide resolved
@elioschmutz elioschmutz force-pushed the es/TI-1540-local-roles-lookup-table branch 5 times, most recently from 706bcd0 to a641a32 Compare November 20, 2024 09:18
@elioschmutz
Copy link
Member Author

elioschmutz commented Nov 22, 2024

@lukasgraf @buchi I've updated the PR with your suggestions. The main difference is the use of composite primary keys and the easier update implementation.

@elioschmutz elioschmutz force-pushed the es/TI-1540-local-roles-lookup-table branch from a641a32 to f7b20f5 Compare November 25, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants