-
Notifications
You must be signed in to change notification settings - Fork 15
chore: Namespace Selection #365
base: main
Are you sure you want to change the base?
chore: Namespace Selection #365
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Kells512!
I have some minor comments before merging this one.
Could you please group all the Namespace variants in a single folder?
You could also move it inside src/app/components/POCs
, I think.
Just to keep things more organized.
Also I've noticed that you added a git submodule in a new sandbox-ui
empty folder. I guess it wasn't intentional. If so, could you get rid of it?
export default { | ||
title: "PoCs/Namespace 2", | ||
component: ComposableContextSelector, | ||
args: {}, | ||
decorators: [], | ||
} as ComponentMeta<typeof ComposableContextSelector>; | ||
|
||
const Template: ComponentStory<typeof ComposableContextSelector> = (args) => ( | ||
<ComposableContextSelector {...args} /> | ||
); | ||
|
||
export const Story = Template.bind({}); | ||
Story.args = {}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be nicer if all the Namespace
stories were grouped in a single "folder" within Storybook.
To do so it's enough to provide the same title to all of them, like title: "PoCs/Namespace"
Then you can give each story a different name by doing something like this:
export const Namespace2 = Template.bind({});
Namespace2.args = {};
No description provided.