Feature/#50

[dsilhavy]

This PR adds an optional flag finish_file_transmissions to the deactivate method of the transmitter. If this flag is set to true we will only deactivate the transmitter once all files in the queue has been sent.

This addresses #50

[davidjwbbc]

Looks good, just have a code suggestion to make the interface more compact.

[rjb1000]

After discussing this, we believe there is value in moving this functionality into the FLUTE library so that any application can benefit from the feature.

@davidjwbbc: Please could you add a new backlog issue to the MBSTF project to remove the code from there and use this new library flag instead? (It should reference this feature issue, of course.)

[dsilhavy]

After discussing this, we believe there is value in moving this functionality into the FLUTE library so that any application can benefit from the feature.

@davidjwbbc: Please could you add a new backlog issue to the MBSTF project to remove the code from there and use this new library flag instead? (It should reference this feature issue, of course.)

Thanks for the update, I will address the remaining comment by @davidjwbbc. Do you want me to leave this PR open until it has been verified in the MBSTF or should we go ahead and merge this to development once the comments have been addressed and you test it from there?

[davidjwbbc]

I think it's fine to merge before any MBSTF changes.

It may be that the MBSTF still has to use the completed callback to avoid thread blocking and maintain synchronisation with the FLUTE library. I still have to look at the MBSTF code and see how easy/possible it will be to change to using this new interface.