Skip to content

Add ability to set multicast source address - #59

Merged
davidjwbbc merged 3 commits into
5G-MAG:developmentfrom
davidjwbbc:feature/ssm-source
Apr 8, 2026
Merged

Add ability to set multicast source address#59
davidjwbbc merged 3 commits into
5G-MAG:developmentfrom
davidjwbbc:feature/ssm-source

Conversation

@davidjwbbc

Copy link
Copy Markdown
Contributor

This is a new optional parameter when constructing a Transmitter object to maintain backward compatibility.

When not provided the operation remains the same as before, i.e. pick the address of the appropriate local interface.

When source address is provided:

  • When used with a tunnel endpoint this will set the encapsulated source IP address to be used.
  • When used without a tunnel endpoint this will bind the output socket to the provided address.
    • An exception is raised if the output socket cannot be bound to the given source address using bind().

Closes #58
Unblocks 5G-MAG/rt-mbs-transport-function#56

@davidjwbbc davidjwbbc self-assigned this Apr 7, 2026
@davidjwbbc davidjwbbc added the enhancement New feature or request label Apr 7, 2026
@davidjwbbc davidjwbbc moved this to Ready for review in 5MBS: User Services initial release Apr 7, 2026
@davidjwbbc davidjwbbc added this to the v0.12.3 milestone Apr 7, 2026
@davidjwbbc davidjwbbc linked an issue Apr 7, 2026 that may be closed by this pull request

@jordijoangimenez jordijoangimenez left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good, @davidjwbbc.
Unrelated to your change but I find now a bit confusing that the multicast group address is just called "address" in the constructor.

Would it be very painful in terms of rewriting to call it eg m_address where used? If painful. Let's go and merge this one.

rjb1000
rjb1000 previously approved these changes Apr 8, 2026
@davidjwbbc

davidjwbbc commented Apr 8, 2026

Copy link
Copy Markdown
Contributor Author

This is good, @davidjwbbc. Unrelated to your change but I find now a bit confusing that the multicast group address is just called "address" in the constructor.

Would it be very painful in terms of rewriting to call it eg m_address where used? If painful. Let's go and merge this one.

I'd prefer a different name, maybe something like multicast_address, group_address or destination_address as we have often, in other projects, used the m_ variable prefix to indicate the use of an object member variable and it might get confusing.

Plus it always helps to be a bit more explicit with variable names, rather than trying to abbreviate.

@jordijoangimenez

Copy link
Copy Markdown
Contributor

Thanks, David. Any of the three options look good. Perhaps destination address? (then we have source and destination more explicit=

@davidjwbbc
davidjwbbc dismissed stale reviews from rjb1000 and jordijoangimenez via ec9119c April 8, 2026 11:10
@davidjwbbc

Copy link
Copy Markdown
Contributor Author

@jordijoangimenez, I've done the destination_address change and updated the code documentation to match. I've also updated the Doxyfile too since my doxygen command was complaining it was old.

@jordijoangimenez

Copy link
Copy Markdown
Contributor

@davidjwbbc please merge

@davidjwbbc
davidjwbbc merged commit ec9119c into 5G-MAG:development Apr 8, 2026
2 checks passed
@github-project-automation github-project-automation Bot moved this from Ready for review to Done in 5MBS: User Services initial release Apr 8, 2026
@davidjwbbc
davidjwbbc deleted the feature/ssm-source branch April 8, 2026 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Development

Successfully merging this pull request may close these issues.

Libflute: Add SSM source address to Transmitter configuration

3 participants