Add ability to set multicast source address - #59
Conversation
There was a problem hiding this comment.
This is good, @davidjwbbc.
Unrelated to your change but I find now a bit confusing that the multicast group address is just called "address" in the constructor.
Would it be very painful in terms of rewriting to call it eg m_address where used? If painful. Let's go and merge this one.
I'd prefer a different name, maybe something like Plus it always helps to be a bit more explicit with variable names, rather than trying to abbreviate. |
|
Thanks, David. Any of the three options look good. Perhaps |
ec9119c
|
@jordijoangimenez, I've done the |
|
@davidjwbbc please merge |
This is a new optional parameter when constructing a
Transmitterobject to maintain backward compatibility.When not provided the operation remains the same as before, i.e. pick the address of the appropriate local interface.
When source address is provided:
bind().Closes #58
Unblocks 5G-MAG/rt-mbs-transport-function#56