Bug-fix: Fix incorrect function call during FLUTE object compression - #69
Merged
Merged
Conversation
rjb1000
approved these changes
Aug 21, 2026
There was a problem hiding this comment.
I wonder how long this bug has been in the library?
I suspect you're the first person ever to follow this code path, @davidjwbbc!
jordijoangimenez
approved these changes
Aug 21, 2026
jordijoangimenez
left a comment
jordijoangimenez
left a comment
Contributor
There was a problem hiding this comment.
Great finding from @davidjwbbc
github-project-automation
Bot
moved this from Ready for review
to Done
in 5MBS: User Services initial release
This was referenced Aug 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After triggering object compression, while testing 5G-MAG/rt-mbs-transport-function#66, it was noted that the FLUTE library often crashed trying to compress the file object. This was due to a copy/paste error from the decompression routine which mistakenly used
inflate()instead ofdeflate()during compression.This PR corrects the compression routine to use
deflate()correctly.