🎨 Palette: Fix heading hierarchy in nested UI cards#84
🎨 Palette: Fix heading hierarchy in nested UI cards#84NickJLange wants to merge 1 commit intomainfrom
Conversation
- Changed the `<h3>` wrapping the post title in the "Latest Update" card to an `<h4>`. - This fixes an accessibility issue where nested cards were using the same heading level as their parent section, disrupting the logical document outline for screen reader users. - Added a new entry to the `.Jules/palette.md` journal detailing this learning. Co-authored-by: NickJLange <1529105+NickJLange@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What: Changed the
<h3>wrapping the post title inside the "Latest Update" card to an<h4>insrc/components/HomepageContent/index.js.🎯 Why: To improve semantic heading hierarchy. The "Latest Update" section itself is an
<h3>. Nesting another<h3>immediately inside it for the card title disrupts the logical document outline, making it confusing for screen reader users navigating by headings.♿ Accessibility: This directly improves accessibility by ensuring heading levels correctly increment, allowing screen readers to accurately represent the relationship between the section and its contents.
📝 Journal Entry: A new critical learning regarding heading hierarchy in nested UI components was added to
.Jules/palette.md.PR created automatically by Jules for task 14610081192161817067 started by @NickJLange
Summary by cubic
Fixed the heading hierarchy in the “Latest Update” card by changing the post title from h3 to h4. This keeps the outline under the section’s h3 and improves screen reader navigation.
Written for commit 6e26451. Summary will update on new commits.